API groups e2e tests remove controllers #3564

codegold79 · 2021-03-11T22:36:53Z

Summary of changes

removed controllers and webhooks unnecessary for testing API group version feature
replaced many of the sleeps with --wait and other more deterministic blocking methods

Does your change fix a particular issue?

Fixes #3532

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file or added /kind changelog-not-required.
Updated the corresponding documentation in site/content/docs/main.

codegold79 · 2021-03-11T22:37:21Z

/kind changelog-not-required

codegold79 · 2021-03-11T22:38:50Z

@ashish-amarnath I have reason to believe a bug was introduced by Velero recently somewhere.
For my API Group Versions e2e tests, I created two images: current one (should be the same as main as of today, March 11, 2021) and an older one from when I first published my API Groups PR (published Feb 4, 2021). The older image consistently passes. The newest image always fails. I’m currently on the search to identify the bug.

codegold79 · 2021-03-12T16:50:52Z

These tests currently do not pass because PR #3125 removed API group version feature changes. PR #3571 bug issue was created to address the issue. In the meantime, in order to get tests to pass, build a local Velero version at a commit that is before the merge of PR #3125.

test/e2e/testdata/enable_api_group_versions/music_v2beta2_rockband.yaml

codegold79 · 2021-03-25T23:32:14Z

I put this PR in DRAFT status as it has merge conflicts.

Signed-off-by: F. Gold <fgold@vmware.com>

codegold79 · 2021-06-03T20:34:53Z

@dsu-igeek @zubron, this PR is again ready for review after I fixed merge conflicts introduced when PR #3726 was merged.

dsu-igeek

Just a couple of small changes, thanks!

test/e2e/enable_api_group_versions_test.go

test/e2e/testdata/enable_api_group_versions/README.md

Signed-off-by: F. Gold <fgold@vmware.com>

codegold79 · 2021-06-15T16:29:35Z

Looks like merge conflicts were introduced with PR #3764 less than a week ago. I'll have to address these.

Signed-off-by: F. Gold <fgold@vmware.com>

…remove-controllers

Signed-off-by: F. Gold <fgold@vmware.com>

carlisia

@codegold79 the test failed, please see the output: https://snippets.cacher.io/snippet/07d40f30c84fa9f49bcd

carlisia

This PR lgtm, it's basically a removal of a bunch of resources. The failure I got was about generating the data, maybe a timeout.

Next: I'm going to run what we have on the main branch and see if that passes.

codegold79 · 2021-06-15T21:35:18Z

This PR lgtm, it's basically a removal of a bunch of resources. The failure I got was about generating the data, maybe a timeout.

Next: I'm going to run what we have on the main branch and see if that passes.

Thanks @carlisia for running the tests. I'll stand by and see if I can make any changes to help get the tests to pass.

carlisia · 2021-06-15T21:59:16Z

@codegold79 it got worse: https://snippets.cacher.io/snippet/137ff753cef67263363a

codegold79 · 2021-06-15T22:01:34Z

@codegold79 it got worse: https://snippets.cacher.io/snippet/137ff753cef67263363a

Oh no! Kibishii tests are really struggling :(

carlisia

These tests run successfully on AWS.

All the chocking reported previously was mostly due to race conditions from running all tests together and from all tests installing Velero in the same namespace.

Note: I fixed the race conditions (🎉) and will open a PR for that tomorrow. No changes were made to this test after the race conditions and they pass successfully.

dsu-igeek

LGTM

* Remove controllers and sleeps in API groups e2e tests Signed-off-by: F. Gold <fgold@vmware.com> * Print command in AfterEach(...) and check error Signed-off-by: F. Gold <fgold@vmware.com> * Make change ahead of PR3764 changes in main Signed-off-by: F. Gold <fgold@vmware.com> * Update go.{mod,sum} files Signed-off-by: F. Gold <fgold@vmware.com> * Run make update Signed-off-by: F. Gold <fgold@vmware.com>

github-actions bot added the has-e2e-tests label Mar 11, 2021

github-actions bot requested review from jenting and zubron March 11, 2021 22:37

github-actions bot assigned codegold79 Mar 11, 2021

github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Mar 11, 2021

codegold79 changed the title ~~Api groups e2e tests remove controllers~~ API groups e2e tests remove controllers Mar 11, 2021

codegold79 marked this pull request as draft March 11, 2021 22:39

codegold79 mentioned this pull request Mar 12, 2021

PR 3125 Breaks API Group Versions Feature (PR 3133) #3571

Closed

codegold79 marked this pull request as ready for review March 12, 2021 16:51

github-actions bot requested review from ashish-amarnath and dsu-igeek March 12, 2021 16:51

codegold79 mentioned this pull request Mar 12, 2021

Flaky e2e tests #3532

Closed

dsu-igeek added this to In progress in v1.6.0 via automation Mar 13, 2021

dsu-igeek added this to the v1.6.0 milestone Mar 13, 2021

ashish-amarnath reviewed Mar 13, 2021

View reviewed changes

test/e2e/testdata/enable_api_group_versions/music_v2beta2_rockband.yaml Show resolved Hide resolved

dsu-igeek added this to In progress in v1.7.0 via automation Mar 13, 2021

dsu-igeek removed this from In progress in v1.6.0 Mar 13, 2021

dsu-igeek modified the milestones: v1.6.0, v1.7.0 Mar 13, 2021

codegold79 marked this pull request as draft March 25, 2021 23:31

codegold79 marked this pull request as ready for review April 1, 2021 18:36

codegold79 marked this pull request as draft April 1, 2021 18:37

carlisia removed the request for review from jenting April 15, 2021 22:28

dsu-igeek removed this from In progress in v1.7.0 Apr 21, 2021

dsu-igeek added this to In progress in Velero 1.7.0 via automation Apr 21, 2021

codegold79 force-pushed the api-groups-e2e-tests-remove-controllers branch from 331fc4f to 78ac41a Compare April 27, 2021 21:14

codegold79 marked this pull request as ready for review April 27, 2021 21:30

codegold79 requested a review from ashish-amarnath April 27, 2021 21:31

Remove controllers and sleeps in API groups e2e tests

40cd94b

Signed-off-by: F. Gold <fgold@vmware.com>

codegold79 force-pushed the api-groups-e2e-tests-remove-controllers branch from 78ac41a to 40cd94b Compare June 3, 2021 20:28

dsu-igeek reviewed Jun 7, 2021

View reviewed changes

test/e2e/enable_api_group_versions_test.go Outdated Show resolved Hide resolved

test/e2e/testdata/enable_api_group_versions/README.md Show resolved Hide resolved

Print command in AfterEach(...) and check error

dc1250b

Signed-off-by: F. Gold <fgold@vmware.com>

codegold79 added 3 commits June 15, 2021 09:45

Make change ahead of PR3764 changes in main

0a90716

Signed-off-by: F. Gold <fgold@vmware.com>

Merge remote-tracking branch 'origin/main' into api-groups-e2e-tests-…

7821ff3

…remove-controllers

Update go.{mod,sum} files

caa4529

Signed-off-by: F. Gold <fgold@vmware.com>

codegold79 force-pushed the api-groups-e2e-tests-remove-controllers branch from cc2d736 to caa4529 Compare June 15, 2021 17:23

Run make update

d7c2b02

Signed-off-by: F. Gold <fgold@vmware.com>

carlisia self-requested a review June 15, 2021 18:11

carlisia reviewed Jun 15, 2021

View reviewed changes

codegold79 requested a review from dsu-igeek June 15, 2021 21:35

carlisia removed the request for review from ashish-amarnath June 17, 2021 06:54

carlisia approved these changes Jun 17, 2021

View reviewed changes

Velero 1.7.0 automation moved this from In progress to Reviewer approved Jun 17, 2021

dsu-igeek approved these changes Jun 17, 2021

View reviewed changes

dsu-igeek merged commit c21b661 into vmware-tanzu:main Jun 17, 2021

Velero 1.7.0 automation moved this from Reviewer approved to Done Jun 17, 2021

zubron mentioned this pull request Jun 21, 2021

Add cherry-pick commits and changelog for v1.6.1 #3889

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API groups e2e tests remove controllers #3564

API groups e2e tests remove controllers #3564

codegold79 commented Mar 11, 2021 •

edited

codegold79 commented Mar 11, 2021

codegold79 commented Mar 11, 2021

codegold79 commented Mar 12, 2021 •

edited

codegold79 commented Mar 25, 2021

codegold79 commented Jun 3, 2021

dsu-igeek left a comment

codegold79 commented Jun 15, 2021

carlisia left a comment

carlisia left a comment

codegold79 commented Jun 15, 2021 •

edited

carlisia commented Jun 15, 2021

codegold79 commented Jun 15, 2021

carlisia left a comment •

edited

dsu-igeek left a comment

API groups e2e tests remove controllers #3564

API groups e2e tests remove controllers #3564

Conversation

codegold79 commented Mar 11, 2021 • edited

Summary of changes

Does your change fix a particular issue?

Please indicate you've done the following:

codegold79 commented Mar 11, 2021

codegold79 commented Mar 11, 2021

codegold79 commented Mar 12, 2021 • edited

codegold79 commented Mar 25, 2021

codegold79 commented Jun 3, 2021

dsu-igeek left a comment

Choose a reason for hiding this comment

codegold79 commented Jun 15, 2021

carlisia left a comment

Choose a reason for hiding this comment

carlisia left a comment

Choose a reason for hiding this comment

codegold79 commented Jun 15, 2021 • edited

carlisia commented Jun 15, 2021

codegold79 commented Jun 15, 2021

carlisia left a comment • edited

Choose a reason for hiding this comment

dsu-igeek left a comment

Choose a reason for hiding this comment

codegold79 commented Mar 11, 2021 •

edited

codegold79 commented Mar 12, 2021 •

edited

codegold79 commented Jun 15, 2021 •

edited

carlisia left a comment •

edited