Enable the E2E test on Github Action #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
210627_github_action
branch
from
0a738a6
to
a0ec855
Compare
ywk253100
force-pushed
the
210627_github_action
branch
from
a0ec855
to
d9d2ad8
Compare
github-actions
bot
added
Area/Design
ywk253100
force-pushed
the
210627_github_action
branch
from
d9d2ad8
to
747191f
Compare
github-actions
bot
removed
Documentation
Dependencies
ywk253100
force-pushed
the
210627_github_action
branch
from
747191f
to
ba08d7d
Compare
ywk253100
requested review from
reasonerjt,
danfengliu and
dsu-igeek
and removed request for
carlisia and
jenting
dsu-igeek
suggested changes
Jun 30, 2021
.github/workflows/e2e-test-kind.yaml
Outdated
| if: steps.image-cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| IMAGE=velero VERSION=main make container | ||
| docker save velero:main -o ./velero.tar |
There was a problem hiding this comment.
Let's call the image version "pr-test" or if possible, something unique. That will keep us from ever getting confused that main is under test.
ywk253100
force-pushed
the
210627_github_action
branch
from
ba08d7d
to
be66b55
Compare
1. Run the E2E test with kind(provision various versions of k8s cluster) and MinIO on Github Action 2. Bug fix: the variable "stdoutBuf" is assigned to both "installPluginCmd.Stdout" and "installPluginCmd.Stderr", this causes 'if !strings.Contains(stderrBuf.String(), "Duplicate value")' takes no effect as the "stderrBuf.String()" is always empty 3. Print the stdout and stderr for easy debugging Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
210627_github_action
branch
from
be66b55
to
bb05ed3
Compare
reasonerjt
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.