Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for setting securityContext for restic restore #4084

Merged
merged 7 commits into from
Feb 24, 2022

Conversation

MatthieuFin
Copy link
Contributor

@MatthieuFin MatthieuFin commented Aug 31, 2021

Summary of changes

Add a key secCtx in configuration configMap "velero.io/restic: RestoreItemAction" to be able to fully customize securityContext set on restic-wait init container set on restore job.

This key is an extension of existing keys secCtxRunAsUser, secCtxRunAsGroup, secCtxAllowPrivilegeEscalation. I keep these old keys support to assure a backward compatibility. But usage of the key secCtx could override old keys (unit tests should be clear).

Issue

Complete implementation for half implemented issue #2290

Please indicate you've done the following:

…iner

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
…ion.

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Documentation has-unit-tests has-changelog labels Aug 31, 2021
Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
@MatthieuFin MatthieuFin marked this pull request as ready for review August 31, 2021 15:52
@jenting jenting requested review from reasonerjt, ywk253100, zubron and dsu-igeek and removed request for a-mccarthy September 1, 2021 03:15
@dsu-igeek dsu-igeek added this to the v1.8.0 milestone Sep 15, 2021
@dsu-igeek dsu-igeek added this to To Do in v1.8.0 Oct 20, 2021
@jenting jenting self-requested a review October 21, 2021 02:50
@reasonerjt
Copy link
Contributor

@MatthieuFin Thanks for this PR and it looks good to me, could you rebase your PR and we can try to get this reviewed and merged before v1.8 release.

@reasonerjt
Copy link
Contributor

moving this out of v1.8 milestone as we are very close to the FC.

@reasonerjt reasonerjt removed this from the v1.8.0 milestone Dec 21, 2021
@stale
Copy link

stale bot commented Feb 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Feb 19, 2022
@reasonerjt reasonerjt added this to the 1.9.0 milestone Feb 22, 2022
@stale stale bot removed the staled label Feb 22, 2022
@eleanor-millman
Copy link
Contributor

@MatthieuFin Do you still want to get this merged? If you could do what @reasonerjt suggested we can get it into 1.9. THanks!

@eleanor-millman eleanor-millman removed this from To Do in v1.8.0 Feb 22, 2022
@MatthieuFin
Copy link
Contributor Author

Oh yes, sorry i had broke my notifications settings, il will rebase it asap.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file and removed Dependencies Pull requests that update a dependency file labels Feb 23, 2022
Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
@eleanor-millman
Copy link
Contributor

Thanks! I just mentioned it in the slack channel so hopefully we'll get a maintainers's eyes on it soon. https://kubernetes.slack.com/archives/C021GPR1L3S/p1645634071501639

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question.

pkg/util/kube/security_context_test.go Outdated Show resolved Hide resolved
…rors wanted on equals

Signed-off-by: MatthieuFin <matthieu2717@gmail.com>
@blackpiglet
Copy link
Contributor

Reference #2437 here.
That issue was fixed by this PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Documentation has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants