Return the error if velero failed to detect S3 region for restic repo #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error should be returned explicitly, because when the default URL is used S3 will return a 301 and the response can't be handled by restic. Fixes vmware-tanzu#4178 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
ywk253100
approved these changes
Nov 15, 2021
jenting
approved these changes
Nov 15, 2021
qiuming-best
pushed a commit
to qiuming-best/velero
that referenced
this pull request
Nov 22, 2021
…vmware-tanzu#4343) The error should be returned explicitly, because when the default URL is used S3 will return a 301 and the response can't be handled by restic. Fixes vmware-tanzu#4178 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
qiuming-best
pushed a commit
to qiuming-best/velero
that referenced
this pull request
Nov 22, 2021
…vmware-tanzu#4343) The error should be returned explicitly, because when the default URL is used S3 will return a 301 and the response can't be handled by restic. Fixes vmware-tanzu#4178 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…vmware-tanzu#4343) The error should be returned explicitly, because when the default URL is used S3 will return a 301 and the response can't be handled by restic. Fixes vmware-tanzu#4178 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…vmware-tanzu#4343) The error should be returned explicitly, because when the default URL is used S3 will return a 301 and the response can't be handled by restic. Fixes vmware-tanzu#4178 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error should be returned explicitly, because when the default URL is
used S3 will return a 301 and the response can't be handled by restic.
Fixes #4178
Signed-off-by: Daniel Jiang jiangd@vmware.com
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.