Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the key for GKE zone for AZ collection #4376

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Add the key for GKE zone for AZ collection #4376

merged 1 commit into from
Nov 22, 2021

Conversation

reasonerjt
Copy link
Contributor

Signed-off-by: Daniel Jiang jiangd@vmware.com

Please indicate you've done the following:

jenting
jenting previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was wondering why previous PR #4350 was without the GCP key.

@reasonerjt
Add the key for GKE zone for AZ collection
748cf86 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt
Copy link
Contributor Author

reasonerjt commented Nov 20, 2021 •
edited

Thanks, I was wondering why previous PR #4350 was without the GCP key.

#4350 was submitted to unblock the AWS plugin work. At that moment, the work for GCP plugin was not started and we didn't know the key...

@ywk253100 ywk253100 merged commit 474fd61 into vmware-tanzu:main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywk253100 ywk253100 ywk253100 approved these changes

@jenting jenting jenting approved these changes

@dsu-igeek dsu-igeek Awaiting requested review from dsu-igeek

@zubron zubron Awaiting requested review from zubron

Assignees

@reasonerjt reasonerjt

Labels
has-changelog has-unit-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reasonerjt @ywk253100 @jenting