Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UploadProgressFeature flag to enable UploadProgressMonitoring #4416

Conversation

dsu-igeek
Copy link
Contributor

and ItemSnapshotters. Will be required in 1.8 to use the upload progress monitoring or item snapshotters, we will plan to remove in 1.9.

Signed-off-by: Dave Smith-Uchida dsmithuchida@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@dsu-igeek dsu-igeek added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 1, 2021
@reasonerjt
Copy link
Contributor

How will this feature flag be used?

@dsu-igeek
Copy link
Contributor Author

This will be used to enable upload progress monitoring and itemsnapshotters. When it is disabled operations should be the same as currently.

@reasonerjt
Copy link
Contributor

I suppose in this commit there should also be some code to check this flag? like

if features.IsEnabled(velerov1api.UploadProgressFeatureFlag) {
...
} else {
...
}

@dsu-igeek
Copy link
Contributor Author

That's basically going to be all of the code. I wanted to just get this in early so I could get in the parts that are covered by it without having a dependency.

@reasonerjt
Copy link
Contributor

Please commit the changelog and I'll approve.

…nd ItemSnapshotters

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
@dsu-igeek dsu-igeek force-pushed the dsu-upload-progress-feature-flag-12-01-2021 branch from 98e1e66 to d0e660f Compare December 7, 2021 08:06
@dsu-igeek
Copy link
Contributor Author

Added a changelog

@dsu-igeek dsu-igeek removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 7, 2021
@ywk253100 ywk253100 merged commit 769af3f into vmware-tanzu:main Dec 8, 2021
@dsu-igeek dsu-igeek deleted the dsu-upload-progress-feature-flag-12-01-2021 branch December 8, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants