Migrate backup sync controller from code-generator to kubebuilder #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
requested review from
dsu-igeek,
reasonerjt,
zubron and
ywk253100
blackpiglet
added this to In progress
in Velero v1.8 Sprint 7 (12-Jan-2022)
via automation
blackpiglet
force-pushed
the
4135-convert-backup-sync-to-kubebuilder
branch
2 times, most recently
from
0253587
to
55f9920
Compare
1. use kubebuilder's reconcile logic to replace controller's old logic. 2. use ginkgo and gomega to replace testing. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4135-convert-backup-sync-to-kubebuilder
branch
from
441cb89
to
3893a25
Compare
zubron
reviewed
Dec 6, 2021
blackpiglet
force-pushed
the
4135-convert-backup-sync-to-kubebuilder
branch
2 times, most recently
from
f390a1d
to
8a8d5c0
Compare
1. Remove DefaultBackupLocation 2. Remove unneccessary comment line 3. Add syncPeriod default value setting logic 4. Modify ListBackupStorageLocations function's context parameter 5. Add RequeueAfter parameter in Reconcile function return value Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4135-convert-backup-sync-to-kubebuilder
branch
from
8a8d5c0
to
61578d6
Compare
1. Use context passed from parameter, instead of using Reconciler struct's context. 2. Delete Reconciler struct's context member. 3. Modify test case accordingly. Signed-off-by: Xun Jiang <jxun@vmware.com>
reasonerjt
approved these changes
Dec 14, 2021
zubron
approved these changes
Dec 15, 2021
blackpiglet
pushed a commit
to blackpiglet/velero
that referenced
this pull request
Dec 17, 2021
…lder (vmware-tanzu#4423)" This reverts commit 5aaeb3e.
3 tasks
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…ware-tanzu#4423) * Migrate backup sync controller from code-generator to kubebuilder 1. use kubebuilder's reconcile logic to replace controller's old logic. 2. use ginkgo and gomega to replace testing. Signed-off-by: Xun Jiang <jxun@vmware.com> * Fix: modify code according to comments 1. Remove DefaultBackupLocation 2. Remove unneccessary comment line 3. Add syncPeriod default value setting logic 4. Modify ListBackupStorageLocations function's context parameter 5. Add RequeueAfter parameter in Reconcile function return value Signed-off-by: Xun Jiang <jxun@vmware.com> * Reconcile function use context passed from parameter 1. Use context passed from parameter, instead of using Reconciler struct's context. 2. Delete Reconciler struct's context member. 3. Modify test case accordingly. Signed-off-by: Xun Jiang <jxun@vmware.com>
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…lder (vmware-tanzu#4423)" This reverts commit 5aaeb3e.
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…ware-tanzu#4423) * Migrate backup sync controller from code-generator to kubebuilder 1. use kubebuilder's reconcile logic to replace controller's old logic. 2. use ginkgo and gomega to replace testing. Signed-off-by: Xun Jiang <jxun@vmware.com> * Fix: modify code according to comments 1. Remove DefaultBackupLocation 2. Remove unneccessary comment line 3. Add syncPeriod default value setting logic 4. Modify ListBackupStorageLocations function's context parameter 5. Add RequeueAfter parameter in Reconcile function return value Signed-off-by: Xun Jiang <jxun@vmware.com> * Reconcile function use context passed from parameter 1. Use context passed from parameter, instead of using Reconciler struct's context. 2. Delete Reconciler struct's context member. 3. Modify test case accordingly. Signed-off-by: Xun Jiang <jxun@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…lder (vmware-tanzu#4423)" This reverts commit 5aaeb3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.