E2E test on ssr object with controller namespace mix-ups #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
qiuming-best
requested review from
danfengliu
and removed request for
jenting
qiuming-best
force-pushed
the
ssr-test
branch
from
e39bfef
to
f13155b
Compare
qiuming-best
force-pushed
the
ssr-test
branch
from
f13155b
to
b576bea
Compare
github-actions
bot
removed
the
Dependencies
qiuming-best
changed the title
qiuming-best
force-pushed
the
ssr-test
branch
from
b576bea
to
b4eede2
Compare
ywk253100
reviewed
Jan 13, 2022
| fmt.Sprintf("Failed to create an ssr object in %s namespace", VeleroCfg.VeleroNamespace)) | ||
|
|
||
| var req *v1.ServerStatusRequestList | ||
| By(fmt.Sprintf("Check ssr object in %s namespace", VeleroCfg.VeleroNamespace)) |
There was a problem hiding this comment.
Seems the case doesn't check the CR content of the SSR?
ywk253100
reviewed
Jan 13, 2022
test/e2e/util/k8s/client.go
Outdated
| @@ -45,6 +47,8 @@ type TestClient struct { | |||
| // controller runtime framework by v2.0, it is the intent to remove all | |||
| // client-go API clients. Please use the controller runtime to make API calls for tests. | |||
| dynamicFactory client.DynamicFactory | |||
|
|
|||
| VeleroClient clientset.Interface | |||
There was a problem hiding this comment.
As we are moving to kubebuilder, the generated clientset will be removed after finishing the refactoring. Let's use controller-runtime/pkg/client.Client instead.
There was a problem hiding this comment.
I've changed to controller-runtime/pkg/client.Client
qiuming-best
force-pushed
the
ssr-test
branch
from
b4eede2
to
4f3410e
Compare
github-actions
bot
added
the
Dependencies
qiuming-best
force-pushed
the
ssr-test
branch
from
4f3410e
to
67fcc6d
Compare
github-actions
bot
removed
the
Dependencies
Signed-off-by: Ming <mqiu@vmware.com>
qiuming-best
force-pushed
the
ssr-test
branch
from
67fcc6d
to
f36161e
Compare
ywk253100
approved these changes
Jan 13, 2022
danfengliu
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming mqiu@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
It reference to #4522, it's test on ssr object.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.