Add CSI VolumeSnapshot related metrics. #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
2499-add-metric-for-csi-snapshot
branch
from
fe5dcf6
to
c9ae1dc
Compare
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
2499-add-metric-for-csi-snapshot
branch
from
c9ae1dc
to
4daeec7
Compare
sseago
previously approved these changes
Apr 11, 2022
|
@blackpiglet based on our discussion, getting the storage size of snapshot is tricky so we'll not collect it in v1.9, please remove the related code. |
blackpiglet
force-pushed
the
2499-add-metric-for-csi-snapshot
branch
from
bef6e64
to
e98d363
Compare
…elated code. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
2499-add-metric-for-csi-snapshot
branch
from
e98d363
to
9aa4e9e
Compare
reasonerjt
approved these changes
Apr 15, 2022
pkg/apis/velero/v1/backup.go
Outdated
| // CsiVolumeSnapshotsAttempted is the total number of attempted | ||
| // CSI VolumeSnapshots for this backup. | ||
| // +optional | ||
| CsiVolumeSnapshotsAttempted int `json:"csiVolumeSnapshotsAttempted,omitempty"` |
There was a problem hiding this comment.
for consistency can you rename the fields and funcs from Csixxx to CSIxxx
qiuming-best
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to work when https://github.com/vmware-tanzu/velero-plugin-for-csi added CSI VolumeSnapshot handling code in BackupRequest, but https://github.com/vmware-tanzu/velero-plugin-for-csi is depending on the Velero repository's BackupRequest adding CsiVolumeSnapshots.
So creating this PR first, then make modification on https://github.com/vmware-tanzu/velero-plugin-for-csi to make the adding function work.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #2499
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.