Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CSI VolumeSnapshot metric related code. #4854

Merged

Conversation

blackpiglet
Copy link
Contributor

Signed-off-by: Xun Jiang jxun@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #2499

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Apr 23, 2022
Signed-off-by: Xun Jiang <jxun@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #4854 (22dd0b2) into main (3ec96e2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4854      +/-   ##
==========================================
- Coverage   41.37%   41.37%   -0.01%     
==========================================
  Files         204      204              
  Lines       18061    18062       +1     
==========================================
  Hits         7473     7473              
- Misses      10041    10042       +1     
  Partials      547      547              
Impacted Files Coverage Δ
pkg/controller/backup_controller.go 57.26% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec96e2...22dd0b2. Read the comment docs.

@reasonerjt reasonerjt merged commit 35e9d2f into vmware-tanzu:main Apr 26, 2022
@blackpiglet blackpiglet deleted the add-metric-for-csi-snapshot branch October 15, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report metrics for CSI snapshots
4 participants