Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup restic helper folder when done #4872

Merged
merged 2 commits into from
May 12, 2022

Conversation

big-appled
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

There will be a folder named .velero left in user volume when restore data with restic. We need to remove it when the restic-helper init container done.

Does your change fix a particular issue?

no
Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Ning Ding <834652870@qq.com>
@ywk253100
Copy link
Contributor

@big-appled Could you explain why we need this change?

@big-appled
Copy link
Contributor Author

@big-appled Could you explain why we need this change?

@ywk253100 The folder .velero is left in user volume after restore with restic, which will cause errors for some applications. For example, Kafka, which will treat this folder as an index folder and throw error.
So I think we need clean it up after done.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #4872 (e09c31e) into main (001229a) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4872      +/-   ##
==========================================
- Coverage   41.25%   41.08%   -0.17%     
==========================================
  Files         204      204              
  Lines       18041    18094      +53     
==========================================
- Hits         7442     7434       -8     
- Misses      10047    10109      +62     
+ Partials      552      551       -1     
Impacted Files Coverage Δ
pkg/controller/backup_controller.go 48.07% <0.00%> (-9.93%) ⬇️
pkg/controller/backup_sync_controller.go 58.82% <0.00%> (-2.72%) ⬇️
pkg/controller/pod_volume_backup_controller.go 44.14% <0.00%> (-0.78%) ⬇️
pkg/util/kube/utils.go 74.28% <0.00%> (-0.72%) ⬇️
pkg/restore/restore.go 66.02% <0.00%> (-0.68%) ⬇️
pkg/cmd/server/server.go 6.89% <0.00%> (-0.04%) ⬇️
pkg/controller/pod_volume_restore_controller.go 24.78% <0.00%> (+1.43%) ⬆️
pkg/cmd/cli/restic/server.go 18.06% <0.00%> (+3.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001229a...e09c31e. Read the comment docs.

@ywk253100 ywk253100 added this to the 1.9.0 milestone May 9, 2022
Signed-off-by: Ning Ding <834652870@qq.com>
@reasonerjt reasonerjt merged commit 89907bd into vmware-tanzu:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants