Delete orphan CSI snapshots in backup sync controller #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
force-pushed
the
delete-orphan-vs
branch
from
228ce48
to
f4b32ae
Compare
reasonerjt
force-pushed
the
delete-orphan-vs
branch
3 times, most recently
from
cc3f0c6
to
1007a79
Compare
blackpiglet
previously approved these changes
May 5, 2022
This commit makes backup sync controller delete the volumesnapshot and volumesnapshotcontent created by the backup which is cleaned up as orphan Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
delete-orphan-vs
branch
from
1007a79
to
89e90d9
Compare
blackpiglet
approved these changes
May 5, 2022
ywk253100
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang jiangd@vmware.com
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.