Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make waiting VolumeSnapshot to ready process parallel. #4889

Merged

Conversation

blackpiglet
Copy link
Contributor

Signed-off-by: Xun Jiang jxun@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #4879

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this May 5, 2022
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-changelog labels May 5, 2022
@blackpiglet blackpiglet force-pushed the parallel-VolumeSnapshot-ReadToUse branch from 4da9694 to 8c70f13 Compare May 5, 2022 06:29
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #4889 (8c70f13) into main (aa71427) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 8c70f13 differs from pull request most recent head 6421f8a. Consider uploading reports for the commit 6421f8a to get more accurate results

@@            Coverage Diff             @@
##             main    #4889      +/-   ##
==========================================
- Coverage   41.37%   41.30%   -0.07%     
==========================================
  Files         204      204              
  Lines       17943    17972      +29     
==========================================
  Hits         7424     7424              
- Misses       9972    10001      +29     
  Partials      547      547              
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.89% <0.00%> (-0.02%) ⬇️
pkg/controller/backup_controller.go 55.33% <0.00%> (-2.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71427...6421f8a. Read the comment docs.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet force-pushed the parallel-VolumeSnapshot-ReadToUse branch from 8c70f13 to 6421f8a Compare May 5, 2022 06:33
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@ywk253100 ywk253100 merged commit 6a42d1c into vmware-tanzu:main May 5, 2022
@blackpiglet blackpiglet deleted the parallel-VolumeSnapshot-ReadToUse branch October 15, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make waiting VolumeSnapshot to ready process parallel.
4 participants