-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BSL controller with periodical enqueue source #4894
Conversation
Controller runtime cannot only use Watches function to setup controller. Controller runtime always require a For function. As a result, add BSL in the For function, but even all events of BSL are ignored, there is always some unexpected reconcile running. So need to verify whether need to verify the BSL in the reconcile, instead of only relying on periodical enqueue source. |
Codecov Report
@@ Coverage Diff @@
## main #4894 +/- ##
==========================================
+ Coverage 41.09% 41.63% +0.53%
==========================================
Files 204 204
Lines 18064 18193 +129
==========================================
+ Hits 7424 7574 +150
+ Misses 10093 10044 -49
- Partials 547 575 +28
Continue to review full report at Codecov.
|
3c0536a
to
c8563cc
Compare
284509e
to
af1f9ee
Compare
Add filter functions for PeriodicalEnqueueSource. Move BSL's valication frequency check test case to PeriodicalEnqueueSource's test. Signed-off-by: Xun Jiang <jxun@vmware.com>
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4463
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.