Make garbage collection for expired backups configurable #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
reviewed
May 11, 2022
| @@ -76,7 +78,10 @@ func NewGCController( | |||
| } | |||
|
|
|||
| c.syncHandler = c.processQueueItem | |||
| c.resyncPeriod = GCSyncPeriod | |||
| c.resyncPeriod = frequency | |||
There was a problem hiding this comment.
Better to log the GC sync period for debugging.
qiuming-best
previously approved these changes
May 11, 2022
Make garbage collection for expired backups configurable Fixes vmware-tanzu#4875 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
blackpiglet
approved these changes
May 11, 2022
qiuming-best
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make garbage collection for expired backups configurable
Fixes #4875
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.