Add schedule ordered resources E2E test #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
requested review from
danfengliu and
blackpiglet
and removed request for
reasonerjt
qiuming-best
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4913 +/- ##
==========================================
- Coverage 41.70% 41.69% -0.01%
==========================================
Files 204 204
Lines 18040 18263 +223
==========================================
+ Hits 7523 7615 +92
- Misses 9956 10069 +113
- Partials 561 579 +18
Continue to review full report at Codecov.
|
qiuming-best
force-pushed
the
order-resources-test
branch
from
4d46702
to
e5fa2c0
Compare
danfengliu
reviewed
May 16, 2022
| err := test.Init() | ||
| Expect(err).To(Succeed(), err) | ||
| defer func() { | ||
| Expect(DeleteNamespace(test.Ctx, test.Client, test.Namespace, false)).To(Succeed(), fmt.Sprintf("Failed to delete the namespace %s", test.Namespace)) |
There was a problem hiding this comment.
How about define a function to deal with velero schedule command, then other test cases can reuse it.
There was a problem hiding this comment.
@danfengliu yeah, I've modified
qiuming-best
force-pushed
the
order-resources-test
branch
from
e5fa2c0
to
fddbb32
Compare
Signed-off-by: Ming <mqiu@vmware.com>
qiuming-best
force-pushed
the
order-resources-test
branch
from
fddbb32
to
6b9b137
Compare
danfengliu
approved these changes
May 18, 2022
ywk253100
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming mqiu@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
it refer to #4561, E2E test on schedule ordered resources
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.