Add more information for failing to get path or snapshot in restic ba… #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckup and restore. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
add-more-info-for-get-path-or-snapshot-fail-by-restic
branch
from
8977223
to
806234e
Compare
Codecov Report
@@ Coverage Diff @@
## main #4988 +/- ##
==========================================
- Coverage 41.34% 41.30% -0.05%
==========================================
Files 210 210
Lines 18435 18435
==========================================
- Hits 7622 7614 -8
- Misses 10241 10248 +7
- Partials 572 573 +1
Continue to review full report at Codecov.
|
reasonerjt
reviewed
Jun 13, 2022
| @@ -211,7 +211,7 @@ func (r *PodVolumeBackupReconciler) singlePathMatch(path string) (string, error) | |||
| } | |||
|
|
|||
| if len(matches) != 1 { | |||
| return "", errors.Errorf("expected one matching path, got %d", len(matches)) | |||
| return "", errors.Errorf("expected one matching path: %s, got %d", path, len(matches)) | |||
There was a problem hiding this comment.
Have you checked the value of path I recall it has the wildcard, what does it look like?
There was a problem hiding this comment.
volDir, err := kube.GetVolumeDirectory(ctx, log, pod, pvb.Spec.Volume, r.Client)
if err != nil {
return nil, errors.Wrap(err, "getting volume directory name")
}
pathGlob := fmt.Sprintf("/host_pods/%s/volumes/*/%s", string(pvb.Spec.Pod.UID), volDir)
log.WithField("pathGlob", pathGlob).Debug("Looking for path matching glob")This is the code in PVB controller preparing path before calling the function singlePathMatch.
It has a wildcard, but the volumeDir is also included.
reasonerjt
approved these changes
Jun 13, 2022
qiuming-best
approved these changes
Jun 13, 2022
blackpiglet
deleted the
add-more-info-for-get-path-or-snapshot-fail-by-restic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckup and restore.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.