Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang version to v1.19 for branch main #6039

Merged
merged 2 commits into from Apr 4, 2023

Conversation

blackpiglet
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet
Copy link
Contributor Author

blackpiglet commented Mar 27, 2023

Still cannot workaround the VSC error without adding the -buildvcs=falseflag into the code-generator's script.

error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

I created an issue in the code-generator repository to ask for some help.
kubernetes/code-generator#156

The sed command is removed, by checkout code-generator git repository in the update CRD script.

@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 3 times, most recently from a1ee7a5 to 007f8b2 Compare March 31, 2023 06:46
@blackpiglet blackpiglet marked this pull request as ready for review March 31, 2023 06:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #6039 (42ec721) into main (491664e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6039   +/-   ##
=======================================
  Coverage   41.32%   41.32%           
=======================================
  Files         251      251           
  Lines       23375    23375           
=======================================
  Hits         9660     9660           
  Misses      12957    12957           
  Partials      758      758           
Impacted Files Coverage Δ
pkg/cmd/server/server.go 5.19% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Lyndon-Li
Lyndon-Li previously approved these changes Mar 31, 2023
reasonerjt
reasonerjt previously approved these changes Apr 3, 2023
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackpiglet blackpiglet dismissed stale reviews from reasonerjt and Lyndon-Li via 2771b4b April 4, 2023 02:39
@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 4 times, most recently from 277c976 to 771c345 Compare April 4, 2023 03:48
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 5 times, most recently from 7cf6285 to 4dbffa4 Compare April 4, 2023 04:26
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@Lyndon-Li Lyndon-Li merged commit f0ca2ae into vmware-tanzu:main Apr 4, 2023
23 checks passed
kaovilai added a commit to kaovilai/velero that referenced this pull request Apr 5, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 5, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 6, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 11, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 11, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 24, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 24, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Apr 24, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Jul 13, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Jul 21, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Aug 7, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Aug 10, 2023
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
sseago pushed a commit to openshift/velero that referenced this pull request Aug 28, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Sep 1, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Sep 6, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Sep 25, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Sep 27, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Oct 2, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Oct 16, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to openshift/velero that referenced this pull request Oct 24, 2023
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to sseago/velero that referenced this pull request Jan 23, 2024
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
sseago pushed a commit to sseago/velero that referenced this pull request Mar 4, 2024
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

oadp-1.2: Update Makefile.prow to velero-restore-helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants