Update Golang to v1.20 for main branch. #6158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
update_golang_main
branch
from
718962a
to
32d8d4d
Compare
blackpiglet
force-pushed
the
update_golang_main
branch
from
32d8d4d
to
0f496a3
Compare
Codecov Report
@@ Coverage Diff @@
## main #6158 +/- ##
==========================================
+ Coverage 41.28% 41.31% +0.02%
==========================================
Files 251 251
Lines 23399 23402 +3
==========================================
+ Hits 9661 9669 +8
+ Misses 12979 12975 -4
+ Partials 759 758 -1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kaovilai
reviewed
Apr 17, 2023
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| FROM --platform=linux/amd64 golang:1.19-bullseye | |||
| FROM --platform=linux/amd64 golang:1.20-bullseye | |||
There was a problem hiding this comment.
Any chance you can cherrypick changes from #6085 into this PR?
There was a problem hiding this comment.
or I guess merge that then rebase this.
There was a problem hiding this comment.
I prefer to keep the changes in separate PRs.
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
update_golang_main
branch
from
0f496a3
to
0be3f5a
Compare
Lyndon-Li
approved these changes
Apr 17, 2023
qiuming-best
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Due to
actions/setup-python's limitation, golang's version1.20is parsed into1.2. Need to use'1.20'instead.actions/setup-go#326 (comment)
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.