Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linter revive and resolve found errors: part1 #6173

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Apr 23, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #6173 (bed7d82) into main (14f31ee) will increase coverage by 0.02%.
The diff coverage is 42.24%.

@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
+ Coverage   41.29%   41.31%   +0.02%     
==========================================
  Files         251      251              
  Lines       23402    23388      -14     
==========================================
- Hits         9664     9663       -1     
+ Misses      12980    12971       -9     
+ Partials      758      754       -4     
Impacted Files Coverage Δ
pkg/backup/item_backupper.go 73.62% <0.00%> (ø)
...uilder/customresourcedefinition_v1beta1_builder.go 0.00% <0.00%> (ø)
pkg/builder/v1_customresourcedefinition_builder.go 0.00% <0.00%> (ø)
pkg/cmd/cli/nodeagent/server.go 12.44% <0.00%> (ø)
pkg/cmd/util/output/describe.go 0.00% <0.00%> (ø)
pkg/controller/backup_finalizer_controller.go 57.60% <0.00%> (ø)
pkg/controller/backup_operations_controller.go 46.51% <0.00%> (ø)
pkg/controller/pod_volume_restore_controller.go 25.00% <0.00%> (ø)
pkg/controller/server_status_request_controller.go 66.15% <ø> (ø)
pkg/install/install.go 0.00% <0.00%> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review April 23, 2023 11:11
@blackpiglet blackpiglet force-pushed the linter_revive branch 9 times, most recently from 9c52952 to 9ae9acd Compare April 24, 2023 08:47
@blackpiglet blackpiglet changed the title Enable linter revive and resolve found errors. Enable linter revive and resolve found errors: part1 Apr 24, 2023
pkg/install/resources.go Outdated Show resolved Hide resolved
pkg/install/resources.go Outdated Show resolved Hide resolved
Lyndon-Li
Lyndon-Li previously approved these changes Apr 25, 2023
@blackpiglet blackpiglet mentioned this pull request Apr 25, 2023
33 tasks
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Copy link
Contributor

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lgtm! Thanks!

@blackpiglet blackpiglet merged commit 0d1c2dc into vmware-tanzu:main Apr 26, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants