-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linter revive and resolve found errors: part1 #6173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
linter_revive
branch
from
April 23, 2023 10:11
da7d6a2
to
bed7d82
Compare
Codecov Report
@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
+ Coverage 41.29% 41.31% +0.02%
==========================================
Files 251 251
Lines 23402 23388 -14
==========================================
- Hits 9664 9663 -1
+ Misses 12980 12971 -9
+ Partials 758 754 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blackpiglet
force-pushed
the
linter_revive
branch
9 times, most recently
from
April 24, 2023 08:47
9c52952
to
9ae9acd
Compare
blackpiglet
changed the title
Enable linter revive and resolve found errors.
Enable linter revive and resolve found errors: part1
Apr 24, 2023
kaovilai
suggested changes
Apr 25, 2023
blackpiglet
force-pushed
the
linter_revive
branch
from
April 25, 2023 08:17
7b9d264
to
c52c784
Compare
Lyndon-Li
previously approved these changes
Apr 25, 2023
33 tasks
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
linter_revive
branch
from
April 25, 2023 15:15
c52c784
to
180cc4e
Compare
kaovilai
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lgtm! Thanks!
Lyndon-Li
approved these changes
Apr 26, 2023
qiuming-best
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.