Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PVR issue for generic data path #6303

Merged

Conversation

Lyndon-Li
Copy link
Contributor

Fix a PVR issue for generic data path -- the namespace remap was not honored, and enhance the code for better error handling

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li force-pushed the data-mover-generic-data-path-issue-fix branch from 9bea4f5 to 6c16020 Compare May 23, 2023 07:20
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #6303 (6c16020) into main (5cb7217) will decrease coverage by 0.02%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main    #6303      +/-   ##
==========================================
- Coverage   40.98%   40.97%   -0.02%     
==========================================
  Files         255      255              
  Lines       23804    23830      +26     
==========================================
+ Hits         9756     9764       +8     
- Misses      13287    13304      +17     
- Partials      761      762       +1     
Impacted Files Coverage Δ
pkg/controller/pod_volume_restore_controller.go 20.16% <0.00%> (ø)
pkg/uploader/kopia/snapshot.go 32.30% <0.00%> (-1.94%) ⬇️
pkg/uploader/types.go 100.00% <ø> (ø)
pkg/uploader/provider/kopia.go 55.24% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

@Lyndon-Li Lyndon-Li merged commit 53623a7 into vmware-tanzu:main May 23, 2023
22 checks passed
@Lyndon-Li Lyndon-Li deleted the data-mover-generic-data-path-issue-fix branch May 23, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants