Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not persist VolumeSnapshot and VolumeSnapshotContent for snapshot DataMover case #6366

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jun 7, 2023

  1. Because VolumeSnapshot and VolumeSnapshotContent CRs are not kept after the backup is completed, don't persist them in the backup metadata.
  2. Add some builder methods needed by the CSI plugin.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6118

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Lyndon-Li
Lyndon-Li previously approved these changes Jun 8, 2023
Lyndon-Li
Lyndon-Li previously approved these changes Jun 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6366 (0f53fd5) into main (9951358) will decrease coverage by 0.03%.
The diff coverage is 17.85%.

@@            Coverage Diff             @@
##             main    #6366      +/-   ##
==========================================
- Coverage   48.10%   48.08%   -0.03%     
==========================================
  Files         227      227              
  Lines       23316    23342      +26     
==========================================
+ Hits        11217    11224       +7     
- Misses      11250    11265      +15     
- Partials      849      853       +4     
Impacted Files Coverage Δ
pkg/cmd/util/output/backup_describer.go 0.00% <0.00%> (ø)
pkg/cmd/util/output/backup_structured_describer.go 0.00% <0.00%> (ø)
pkg/cmd/cli/backup/create.go 21.25% <22.22%> (-0.29%) ⬇️
pkg/controller/backup_controller.go 57.32% <100.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

@blackpiglet blackpiglet force-pushed the 6118_fix branch 2 times, most recently from bea8bad to fa966d1 Compare June 8, 2023 06:59
…otContent for snapshot DataMover case.

1. Because VolumeSnapshot and VolumeSnapshotContent CRs are not kept after backup completed,
   don't persist them in the backup metadata.
2. Add some builder methods needed by CSI plugin.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@ywk253100 ywk253100 merged commit 9743a7c into vmware-tanzu:main Jun 8, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume Snapshot Data Movement - CSI Plugin dispose VS/VSC
4 participants