-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not persist VolumeSnapshot and VolumeSnapshotContent for snapshot DataMover case #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
6118_fix
branch
2 times, most recently
from
June 7, 2023 14:08
13388cf
to
94d4c5e
Compare
Lyndon-Li
reviewed
Jun 8, 2023
Lyndon-Li
previously approved these changes
Jun 8, 2023
Lyndon-Li
previously approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #6366 +/- ##
==========================================
- Coverage 48.10% 48.08% -0.03%
==========================================
Files 227 227
Lines 23316 23342 +26
==========================================
+ Hits 11217 11224 +7
- Misses 11250 11265 +15
- Partials 849 853 +4
|
blackpiglet
force-pushed
the
6118_fix
branch
2 times, most recently
from
June 8, 2023 06:59
bea8bad
to
fa966d1
Compare
Lyndon-Li
reviewed
Jun 8, 2023
…otContent for snapshot DataMover case. 1. Because VolumeSnapshot and VolumeSnapshotContent CRs are not kept after backup completed, don't persist them in the backup metadata. 2. Add some builder methods needed by CSI plugin. Signed-off-by: Xun Jiang <jxun@vmware.com>
Lyndon-Li
approved these changes
Jun 8, 2023
ywk253100
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6118
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.