Add warning message for volume snapshotter in data mover case. #6377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
add_warning_in_volume_snapshotter_for_data_mover
branch
from
c2051cc
to
c8fd96e
Compare
Codecov Report
@@ Coverage Diff @@
## main #6377 +/- ##
==========================================
- Coverage 48.35% 48.35% -0.01%
==========================================
Files 227 227
Lines 23346 23349 +3
==========================================
Hits 11290 11290
- Misses 11194 11196 +2
- Partials 862 863 +1
|
Lyndon-Li
reviewed
Jun 11, 2023
pkg/backup/item_backupper.go
Outdated
| @@ -458,6 +458,13 @@ func (ib *itemBackupper) takePVSnapshot(obj runtime.Unstructured, log logrus.Fie | |||
| return nil | |||
| } | |||
|
|
|||
| // TODO: Snapshot data mover is only supported for CSI plugin scenario. | |||
There was a problem hiding this comment.
This should be added after if features.IsEnabled(velerov1api.CSIFeatureFlag), if the snapshot request has been handled by CSI, we will not need this warning
There was a problem hiding this comment.
Thanks. Modified.
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
add_warning_in_volume_snapshotter_for_data_mover
branch
from
c8fd96e
to
a5c28ad
Compare
Lyndon-Li
approved these changes
Jun 12, 2023
| // TODO: Snapshot data mover is only supported for CSI plugin scenario by now. | ||
| // Need to add a mechanism to choose running which plugin for resources. | ||
| // After that, this warning can be removed. | ||
| if boolptr.IsSetToTrue(ib.backupRequest.Spec.SnapshotMoveData) { |
There was a problem hiding this comment.
@blackpiglet Maybe also create an issue for this TODO.
shubham-pampattiwar
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.