Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing CompletionTimestamp and metrics when restore moved into terminal phase #6397

Merged

Conversation

Nutrymaco
Copy link
Contributor

Please add a summary of your change

As i understood when we move Restore into terminal phase (Completed, PartiallyFailure, Failure) we should set CompletionTimestamp and register metrics. But if we wait async operations we do not do this.

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

…erminal phase

Signed-off-by: Nutrymaco <efim7299@icloud.com>
@codecov-commenter
Copy link

Codecov Report

Merging #6397 (454fc9b) into main (e3e0ce3) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #6397      +/-   ##
==========================================
- Coverage   51.15%   51.15%   -0.01%     
==========================================
  Files         228      228              
  Lines       23777    23782       +5     
==========================================
+ Hits        12163    12165       +2     
- Misses      10715    10718       +3     
  Partials      899      899              
Impacted Files Coverage Δ
pkg/controller/restore_operations_controller.go 47.10% <33.33%> (-0.15%) ⬇️

@ywk253100 ywk253100 requested a review from sseago June 19, 2023 06:32
@sseago sseago merged commit 8396163 into vmware-tanzu:main Jul 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants