Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of the legacy client code from pkg/cmd directory part 2 #6497

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 14, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6190

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #6497 (9e515ac) into main (b5bd55f) will decrease coverage by 0.18%.
The diff coverage is 68.49%.

@@            Coverage Diff             @@
##             main    #6497      +/-   ##
==========================================
- Coverage   59.98%   59.81%   -0.18%     
==========================================
  Files         230      236       +6     
  Lines       24566    25088     +522     
==========================================
+ Hits        14737    15007     +270     
- Misses       8812     9041     +229     
- Partials     1017     1040      +23     
Impacted Files Coverage Δ
pkg/cmd/cli/restore/create.go 56.13% <31.81%> (ø)
pkg/cmd/cli/backup/logs.go 71.42% <80.48%> (-0.37%) ⬇️
pkg/cmd/cli/backup/get.go 100.00% <100.00%> (+12.50%) ⬆️

... and 7 files with indirect coverage changes

@blackpiglet blackpiglet force-pushed the 6190_fix_part_2 branch 3 times, most recently from ddaec38 to 1964bfc Compare July 14, 2023 09:35
@blackpiglet blackpiglet changed the title 6190 fix part 2 Remove dependency of the legacy client code from pkg/cmd directory part 2 Jul 14, 2023
@blackpiglet blackpiglet marked this pull request as ready for review July 14, 2023 09:36
@blackpiglet blackpiglet force-pushed the 6190_fix_part_2 branch 5 times, most recently from 5bc668f to 9a5017c Compare July 15, 2023 06:57
@ywk253100
Copy link
Contributor

Can we add more unit tests to keep the coverage > 60%?

@blackpiglet blackpiglet force-pushed the 6190_fix_part_2 branch 5 times, most recently from 6448a72 to ece397e Compare July 17, 2023 08:28
…rt 2.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet merged commit 55987c3 into vmware-tanzu:main Jul 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate how to remove the generated legacy client-go code.
4 participants