Allow updated resource version #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## main #6499 +/- ##
==========================================
- Coverage 60.28% 60.27% -0.01%
==========================================
Files 238 238
Lines 25256 25261 +5
==========================================
+ Hits 15226 15227 +1
- Misses 8976 8979 +3
- Partials 1054 1055 +1
|
sseago
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Looks good, but a minor request -- add a comment above the new getResourceClient call giving the reason for grabbing it again, otherwise someone reading through this later may not realize that the reason for calling it a second time is that the version of obj may have changed during plugin calls.
Signed-off-by: Daniel Kucera <daniel.kucera@gmail.com>
|
@sseago , please check updated revision. Thank you. |
sseago
approved these changes
Jul 21, 2023
shubham-pampattiwar
approved these changes
Jul 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
This change will allow changing the object apiVersion using a plugin
Does your change fix a particular issue?
Fixes #6498
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.