Delete PartiallyFailed orphaned backups as well as Completed ones #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vmware-tanzu#6648 Signed-off-by: Scott Seago <sseago@redhat.com>
sseago
force-pushed
the
orphaned-partially-failed
branch
from
31190e4
to
441a32a
Compare
Codecov Report
@@ Coverage Diff @@
## main #6649 +/- ##
==========================================
+ Coverage 60.18% 60.35% +0.17%
==========================================
Files 242 242
Lines 25712 25971 +259
==========================================
+ Hits 15475 15676 +201
- Misses 9156 9192 +36
- Partials 1081 1103 +22
|
shubham-pampattiwar
approved these changes
Aug 14, 2023
|
Looks good, but suggest putting this PR on hold until release-1.12 is cut. |
kaovilai
suggested changes
Aug 16, 2023
|
@sseago |
shubham-pampattiwar
previously approved these changes
Aug 21, 2023
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
blackpiglet
approved these changes
Aug 22, 2023
|
Can we change PR title to "Delete PartiallyFailed orphaned backups as well as Completed ones" ? |
sseago
changed the title
sseago
changed the title
shubham-pampattiwar
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6648
Thank you for contributing to Velero!
When cleaning up orphaned backups, include PartiallyFailed with Completed, since they are treated equivalently by the rest of backup sync.
Does your change fix a particular issue?
Fixes #6648
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.