Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label selector in Resource Modifiers #6704

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Aug 25, 2023

Please add a summary of your change

This pr made some improvements in Resource Modifiers:

  1. add label selector
  2. change the field name from groupKind to groupResource

Does your change fix a particular issue?

N/A

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: lou <alex1988@outlook.com>
@27149chen 27149chen force-pushed the add-label-selector-in-resource-modifier branch from 6431cc0 to f05b024 Compare August 25, 2023 10:47
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #6704 (7271da9) into main (831be07) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #6704      +/-   ##
==========================================
- Coverage   60.33%   60.32%   -0.01%     
==========================================
  Files         242      242              
  Lines       25982    25986       +4     
==========================================
+ Hits        15675    15676       +1     
- Misses       9203     9205       +2     
- Partials     1104     1105       +1     
Files Changed Coverage Δ
internal/resourcemodifiers/resource_modifiers.go 75.65% <66.66%> (-1.83%) ⬇️
.../resourcemodifiers/resource_modifiers_validator.go 100.00% <100.00%> (ø)

Signed-off-by: lou <alex1988@outlook.com>
Signed-off-by: lou <alex1988@outlook.com>
anshulahuja98
anshulahuja98 previously approved these changes Aug 28, 2023
changelogs/unreleased/6704-27149chen Show resolved Hide resolved
@anshulahuja98
Copy link
Collaborator

CC @reasonerjt, we need to put this in 1.12 release branch, do you folks generally handle the cherry pick of such changes to release branch, or can I help in any way here?

Signed-off-by: lou <alex1988@outlook.com>
@anshulahuja98 anshulahuja98 self-requested a review August 31, 2023 05:04
@anshulahuja98 anshulahuja98 merged commit 5dd7c5c into vmware-tanzu:main Aug 31, 2023
23 of 24 checks passed
anshulahuja98 pushed a commit to anshulahuja98/velero that referenced this pull request Aug 31, 2023
* add label selector in resource modifier

Signed-off-by: lou <alex1988@outlook.com>

* add ut

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

---------

Signed-off-by: lou <alex1988@outlook.com>
anshulahuja98 pushed a commit to anshulahuja98/velero that referenced this pull request Aug 31, 2023
* add label selector in resource modifier

Signed-off-by: lou <alex1988@outlook.com>

* add ut

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

---------

Signed-off-by: lou <alex1988@outlook.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
reasonerjt pushed a commit to reasonerjt/velero that referenced this pull request Aug 31, 2023
* add label selector in resource modifier

Signed-off-by: lou <alex1988@outlook.com>

* add ut

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

---------

Signed-off-by: lou <alex1988@outlook.com>
reasonerjt added a commit that referenced this pull request Aug 31, 2023
[1.12] Cherry Pick - add label selector in Resource Modifiers  (#6704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants