Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 6748 #6765

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix issue 6748 #6765

merged 1 commit into from
Sep 6, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Sep 5, 2023

Fix issue #6748. Rollback the changes of setting Kopia repo policy, the policy should get into Kopia repo, because some internal processes of Kopia uploader are retrieving the policy from repo. And also remove the snapshot deletion according to Kopia retention policy as the snapshots should be deleted according to Velero's backup retention policy.

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #6765 (d13a233) into main (8d3a675) will increase coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 89.09%.

@@            Coverage Diff             @@
##             main    #6765      +/-   ##
==========================================
+ Coverage   60.33%   60.46%   +0.13%     
==========================================
  Files         242      242              
  Lines       25992    26018      +26     
==========================================
+ Hits        15681    15731      +50     
+ Misses       9205     9183      -22     
+ Partials     1106     1104       -2     
Files Changed Coverage Δ
pkg/uploader/kopia/shim.go 74.83% <80.00%> (+6.75%) ⬆️
pkg/uploader/kopia/snapshot.go 81.85% <92.50%> (+1.85%) ⬆️

... and 2 files with indirect coverage changes

@qiuming-best qiuming-best merged commit 49bb998 into vmware-tanzu:main Sep 6, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants