[1.12] Issue 6988: udmrepo use region specified in BSL when s3URL is empty #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
blackpiglet
approved these changes
Oct 20, 2023
reasonerjt
approved these changes
Oct 20, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.12 #6991 +/- ##
================================================
- Coverage 60.47% 60.44% -0.03%
================================================
Files 247 247
Lines 26398 26399 +1
================================================
- Hits 15965 15958 -7
- Misses 9312 9319 +7
- Partials 1121 1122 +1
|
blackpiglet
merged commit bbc9790
into
vmware-tanzu:release-1.12
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6988, always get region from BSL if it is not empty