Force to Credentials file when IRSA is configured #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anshulahuja98 and
shubham-pampattiwar
reasonerjt
force-pushed
the
bypass-irsa-kopia
branch
from
7253dc4
to
facc0e8
Compare
reasonerjt
requested review from
ywk253100 and
Lyndon-Li
and removed request for
shubham-pampattiwar and
anshulahuja98
reasonerjt
force-pushed
the
bypass-irsa-kopia
branch
2 times, most recently
from
621f620
to
da87fd6
Compare
kaovilai
suggested changes
Feb 1, 2024
| @@ -0,0 +1 @@ | |||
| Force to Credentials file when IRSA is configured | |||
There was a problem hiding this comment.
Suggested change
| Force to Credentials file when IRSA is configured | |
| Respect and use `credentialsFile` specified in BSL.spec.config when IRSA is configured over Velero Pod Environment credentials |
ywk253100
previously approved these changes
Feb 1, 2024
reasonerjt
force-pushed
the
bypass-irsa-kopia
branch
2 times, most recently
from
026b04e
to
2795d09
Compare
github-actions
bot
added
the
Dependencies
reasonerjt
force-pushed
the
bypass-irsa-kopia
branch
from
2795d09
to
ba17019
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7374 +/- ##
==========================================
- Coverage 61.75% 61.65% -0.10%
==========================================
Files 262 262
Lines 28433 28479 +46
==========================================
Hits 17558 17558
- Misses 9643 9689 +46
Partials 1232 1232 ☔ View full report in Codecov by Sentry. |
This commit makes sure when kopia connects to the repository the crendentials file specified in BSL.spec.config has the higher priority over Pod Environment credentials when IRSA is configured. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
bypass-irsa-kopia
branch
from
ba17019
to
30728c2
Compare
ywk253100
approved these changes
Feb 1, 2024
|
@kaovilai Thanks for the suggestion I've update the changelog as well as the commit message. |
blackpiglet
approved these changes
Feb 1, 2024
kaovilai
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure when kopia connects to the repository the crendentials file has the higher priority when the IRSA is configured.
Thank you for contributing to Velero!
Fixes #7302
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.