Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch newly dynamically provisioned PV with volume info to restore PV's custom setting #7504

Merged

Conversation

allenxu404
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6435

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@allenxu404 allenxu404 force-pushed the pv-patch-in-finalizing-phase branch from 0e5f984 to 769393f Compare March 7, 2024 09:58
@allenxu404 allenxu404 changed the title Patch newly dynamically provisioned PV with voume info to restore PV's custom setting Patch newly dynamically provisioned PV with volume info to restore PV's custom setting Mar 7, 2024
@allenxu404 allenxu404 marked this pull request as draft March 7, 2024 10:00
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 69.48052% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 61.66%. Comparing base (6ec1701) to head (67b5e82).

Files Patch % Lines
pkg/controller/restore_finalizer_controller.go 68.21% 29 Missing and 12 partials ⚠️
pkg/persistence/object_store.go 81.25% 2 Missing and 1 partial ⚠️
pkg/restore/restore.go 75.00% 2 Missing ⚠️
pkg/cmd/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7504    +/-   ##
========================================
  Coverage   61.65%   61.66%            
========================================
  Files         263      263            
  Lines       28680    28824   +144     
========================================
+ Hits        17682    17773    +91     
- Misses       9753     9792    +39     
- Partials     1245     1259    +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenxu404 allenxu404 force-pushed the pv-patch-in-finalizing-phase branch 4 times, most recently from 0d55a62 to 06c6553 Compare March 8, 2024 06:43
@allenxu404 allenxu404 marked this pull request as ready for review March 11, 2024 05:18
@reasonerjt reasonerjt requested review from reasonerjt and removed request for anshulahuja98 March 12, 2024 07:17
pkg/controller/restore_finalizer_controller.go Outdated Show resolved Hide resolved
pkg/controller/restore_finalizer_controller.go Outdated Show resolved Hide resolved
pkg/controller/restore_finalizer_controller.go Outdated Show resolved Hide resolved
pkg/controller/restore_finalizer_controller.go Outdated Show resolved Hide resolved
@allenxu404 allenxu404 force-pushed the pv-patch-in-finalizing-phase branch 4 times, most recently from 387d293 to dc5e033 Compare March 18, 2024 06:03
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Mar 18, 2024
…stom setting of PV

Signed-off-by: allenxu404 <qix2@vmware.com>
@github-actions github-actions bot removed the Dependencies Pull requests that update a dependency file label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The information of PV is lost if it's restored via podvolume path
3 participants