-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snapshot leak for backup #7558
Merged
qiuming-best
merged 1 commit into
vmware-tanzu:main
from
qiuming-best:uploader-fast-fail
Apr 1, 2024
Merged
Fix snapshot leak for backup #7558
qiuming-best
merged 1 commit into
vmware-tanzu:main
from
qiuming-best:uploader-fast-fail
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9db4e24
to
7eed91a
Compare
212f377
to
df02992
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7558 +/- ##
==========================================
+ Coverage 61.84% 61.86% +0.01%
==========================================
Files 265 266 +1
Lines 29356 29375 +19
==========================================
+ Hits 18155 18172 +17
- Misses 9913 9916 +3
+ Partials 1288 1287 -1 ☔ View full report in Codecov by Sentry. |
blackpiglet
reviewed
Mar 26, 2024
blackpiglet
reviewed
Mar 26, 2024
a5448d8
to
205971a
Compare
88bb8d8
to
d9f2c2d
Compare
Lyndon-Li
reviewed
Mar 29, 2024
d9f2c2d
to
5fbbe14
Compare
fb62af8
to
d8beb74
Compare
Signed-off-by: Ming Qiu <ming.qiu@broadcom.com>
d8beb74
to
3d5282e
Compare
Lyndon-Li
approved these changes
Apr 1, 2024
blackpiglet
approved these changes
Apr 1, 2024
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Apr 2, 2024
…fail Fix snapshot leak for backup
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Apr 2, 2024
…fail Fix snapshot leak for backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has-changelog
has-unit-tests
Needs Testing
If you've tested your change but would still like a maintainer to try it in a different environment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
#7503
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.