Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for results of restore exec hook executions in Finalizing phase instead of InProgress phase #7619

Merged

Conversation

allenxu404
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7099

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 82.99320% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 58.49%. Comparing base (f3295cc) to head (2855225).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/restore/restore.go 61.53% 10 Missing and 5 partials ⚠️
pkg/controller/restore_finalizer_controller.go 81.81% 4 Missing and 2 partials ⚠️
pkg/cmd/server/server.go 0.00% 3 Missing ⚠️
internal/hook/wait_exec_hook_handler.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7619      +/-   ##
==========================================
+ Coverage   58.15%   58.49%   +0.34%     
==========================================
  Files         343      343              
  Lines       35770    28457    -7313     
==========================================
- Hits        20801    16646    -4155     
+ Misses      13552    10392    -3160     
- Partials     1417     1419       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenxu404 allenxu404 force-pushed the post_restore_hook_enhancement branch 2 times, most recently from 0e63f73 to a22542f Compare April 3, 2024 09:10
@allenxu404 allenxu404 force-pushed the post_restore_hook_enhancement branch from a22542f to b9b46cc Compare April 8, 2024 09:39
@allenxu404 allenxu404 marked this pull request as ready for review April 8, 2024 09:39
internal/hook/hook_tracker.go Outdated Show resolved Hide resolved
internal/hook/hook_tracker.go Outdated Show resolved Hide resolved
internal/hook/hook_tracker.go Outdated Show resolved Hide resolved
@allenxu404 allenxu404 force-pushed the post_restore_hook_enhancement branch 3 times, most recently from 062b931 to d65edc5 Compare April 12, 2024 06:11
internal/hook/hook_tracker.go Outdated Show resolved Hide resolved
internal/hook/hook_tracker.go Show resolved Hide resolved
pkg/cmd/server/server.go Outdated Show resolved Hide resolved
pkg/cmd/server/server.go Outdated Show resolved Hide resolved
…instead of InProgress phase

Signed-off-by: allenxu404 <qix2@vmware.com>
@allenxu404 allenxu404 force-pushed the post_restore_hook_enhancement branch from d65edc5 to 2855225 Compare April 15, 2024 09:49
@blackpiglet blackpiglet merged commit bc29471 into vmware-tanzu:main Apr 16, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Restore Hooks might attempt to start running before DataDownload operation has release the related PV
3 participants