Bump up to go1.22 #7666
Merged
Bump up to go1.22 #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
reasonerjt
force-pushed
the
bumpup-to-go1.22-new
branch
2 times, most recently
from
351fab3
to
dcd9382
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
==========================================
- Coverage 61.29% 56.86% -4.43%
==========================================
Files 276 343 +67
Lines 31490 28391 -3099
==========================================
- Hits 19301 16144 -3157
- Misses 10830 10849 +19
- Partials 1359 1398 +39 ☔ View full report in Codecov by Sentry. |
reasonerjt
force-pushed
the
bumpup-to-go1.22-new
branch
from
dcd9382
to
a8737a4
Compare
reasonerjt
force-pushed
the
bumpup-to-go1.22-new
branch
3 times, most recently
from
e275545
to
f7613cd
Compare
|
The UT is impacted. Please double-check the change mentioned by @mateusoliveira43. |
The coverage may have to be impacted, b/c the go1.22 stopped skipping the packages that do not include |
reasonerjt
force-pushed
the
bumpup-to-go1.22-new
branch
from
f7613cd
to
36d6996
Compare
This commit bumps up the golang for building and testing velero to v1.22 It also updates controller-gen to v0.14.0 to fix an issue under new versino of go. More details see golang/go#65637 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
bumpup-to-go1.22-new
branch
from
36d6996
to
1b3fe95
Compare
blackpiglet
approved these changes
Apr 15, 2024
ywk253100
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up the golang version to v1.22
It also updates controller-gen to v0.14.0 to fix an issue under new
version of go.
More details see golang/go#65637
It's known that it causes decrease to the coverage on codecov due to the change in go1.22 to calculate coverage
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.