Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset VolumeSnapshotRef in Backup Sync Flow #7983

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

anshulahuja98
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Follow on fix to #7924
Fixes: #7978

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@anshulahuja98
Copy link
Collaborator Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (d1d331f) to head (4a6a362).
Report is 22 commits behind head on main.

Files Patch % Lines
pkg/controller/backup_sync_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7983      +/-   ##
==========================================
+ Coverage   58.77%   58.82%   +0.05%     
==========================================
  Files         345      346       +1     
  Lines       28768    28854      +86     
==========================================
+ Hits        16908    16973      +65     
- Misses      10430    10449      +19     
- Partials     1430     1432       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +287 to +288
Namespace: "ns-" + string(snapCont.UID),
Name: "name-" + string(snapCont.UID),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this snapshot namespacedname supposed to be non-existing?
Can the string here be anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaovilai this is a copy paste from -https://github.com/vmware-tanzu/velero/blame/824bebbad7bc61077c6e80731468fb020d3dfd4f/pkg/util/csi/volume_snapshot.go#L641

My understanidng is that any name should work here.
We are creating a static VSC

@Lyndon-Li Lyndon-Li added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Jul 11, 2024
@Lyndon-Li Lyndon-Li merged commit 6a3e226 into vmware-tanzu:main Jul 11, 2024
67 of 70 checks passed
@kaovilai
Copy link
Contributor

1.14 cherry-pick: #8003

anshulahuja98 pushed a commit to anshulahuja98/velero that referenced this pull request Jul 12, 2024
Reset VolumeSnapshotRef in Backup Sync Flow
anshulahuja98 pushed a commit to anshulahuja98/velero that referenced this pull request Jul 12, 2024
Reset VolumeSnapshotRef in Backup Sync Flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VolumeSnapshotContents Synced across clusters are rePUT because of incorrect source
4 participants