🌱 Bump up min go version to 1.20 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruneshpa
force-pushed
the
controller-runtime-bump
branch
from
08e6868
to
36ac1e3
Compare
dilyar85
reviewed
Sep 25, 2023
aruneshpa
force-pushed
the
controller-runtime-bump
branch
from
36ac1e3
to
c82e7c6
Compare
dilyar85
approved these changes
Sep 25, 2023
aruneshpa
force-pushed
the
controller-runtime-bump
branch
from
c82e7c6
to
6c21394
Compare
controller-runtime v15 has a min Golang version requirement that breaks the container builds. This change bumps up the Go version used to build the container. Starting 1.21 Golang, go.mod requires the Go version and treats that as min required go version to compile your binary. So, also bump up the Go version for local builds. Additional changes: - As per golang/go#56319 and golang/go#54880, global rand is automatically, randomly seeded. So we don't need to call `Seed` anymore. - Package ioutil has been deprecated. Port the code to use replacement methods.
aruneshpa
force-pushed
the
controller-runtime-bump
branch
from
6c21394
to
6a350ff
Compare
github-actions
bot
added
size/S
Minimum allowed line rate is |
bryanv
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
controller-runtimev15 has a min Golang version requirement that breaks the container builds. This change bumps up the Go version used to build the container. Starting 1.21 Golang, go.mod requires the Go version and treats that as min required go version to compile your binary. So, also bump up the Go version for local builds.Which issue(s) is/are addressed by this PR?
N/A
Are there any special notes for your reviewer:
N/A
Please add a release note if necessary: