Support e2e integration tests w all webhooks & controller #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/e2e-integration-test
branch
from
9dc0f63
to
8ed73e6
Compare
akutz
changed the title
akutz
force-pushed
the
feature/e2e-integration-test
branch
2 times, most recently
from
4795034
to
cd8c2c9
Compare
This patch introduces the new function "NewTestSuiteWithOptions" for creating a test suite that supports all webhooks, both conversion and admission, as well as controllers. This enables end-to-end testing of a controller via integration tests where the production webhooks are installed and part of the reconciliation.
akutz
force-pushed
the
feature/e2e-integration-test
branch
from
cd8c2c9
to
6448032
Compare
Minimum allowed line rate is |
bryanv
reviewed
Dec 29, 2023
| }, | ||
| MutationWebhooks: []builder.TestSuiteMutationWebhookOptions{ | ||
| { | ||
| Name: "default.mutating.virtualmachine.v1alpha1.vmoperator.vmware.com", |
There was a problem hiding this comment.
If we're trying to mimic the actual env, the v1a1 webhooks aren't enabled in v1a2.
bryanv
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch introduces the new function
NewTestSuiteWithOptionsfor creating a test suite that supports all webhooks, both conversion and admission, as well as controllers. This enables end-to-end testing of a controller via integration tests where the production webhooks are installed and part of the reconciliation.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
I am not going to implement the new test suite for all controllers in this one PR. I've implemented for the
VirtualMachinecontrollers (v1a1 and v1a2) as an example, and follow-up PRs can implement the new suite for the other controllers.Please add a release note if necessary: