-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Introduce the ExtraConfig key to allow opt-out from auto register #631
Merged
aruneshpa
merged 1 commit into
vmware-tanzu:main
from
aruneshpa:topic/parunesh/VMSVC-2020/disable-automatic-registration-annotation
Jul 18, 2024
Merged
🌱 Introduce the ExtraConfig key to allow opt-out from auto register #631
aruneshpa
merged 1 commit into
vmware-tanzu:main
from
aruneshpa:topic/parunesh/VMSVC-2020/disable-automatic-registration-annotation
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyar85
reviewed
Jul 18, 2024
Currently, we will unconditionally try to register a VM when it is restored using a backup/restore vendor, or a DR solution. This isn't always ideal if the solution wants to prepare the infra, or customize the VM on vSphere before registering the VM with Supervisor. This change introduces an ExtraConfig key that can be used to opt-out of the automatic registration workflow.
b77bf1c
to
4664453
Compare
dilyar85
approved these changes
Jul 18, 2024
bryanv
approved these changes
Jul 18, 2024
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Currently, we will unconditionally try to register a VM when it is restored using a backup/restore vendor, or a DR solution. This isn't always ideal if the solution wants to prepare the infra, or customize the VM on vSphere before registering the VM with Supervisor.
This change introduces an ExtraConfig key that can be used to opt-out of the automatic registration workflow.
Please add a release note if necessary: