Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Diane Wang <dianew@vmware.com>
  • Loading branch information
Tomorrow9 committed Dec 13, 2023
1 parent a766e07 commit f67b99a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
6 changes: 4 additions & 2 deletions windows/guest_customization/check_autologon_count.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
- name: "Check logon as Administrator automatically is enabled"
ansible.builtin.assert:
that:
- "{{ auto_admin_logon | int == 1 }}"
- auto_admin_logon | int == 1
success_msg: "Logon as Administrator automatically is enabled in guest OS."
fail_msg: "Logon as Administrator automatically registry value '{{ auto_admin_logon }}' is not equal to 1."
fail_msg: >-
Logon as Administrator automatically is not enabled in guest OS,
got registry value '{{ auto_admin_logon }}', not expected value 1.
- name: "Get number of times to logon as Administrator automatically"
ansible.windows.win_shell: >-
Expand Down
4 changes: 2 additions & 2 deletions windows/guest_customization/gosc_sanity_dhcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: BSD-2-Clause
---
# Description:
# This test case is used for check guest OS customization (GOSC)
# This test case is used for checking guest OS customization (GOSC)
# with DHCP network configuration. If VMware Tools is not installed,
# the test result is 'Blocked'.
# Note: VM guest OS customization requires vCenter server.
Expand All @@ -13,5 +13,5 @@
vars:
gosc_network_type: "dhcp"
tasks:
- name: "GOSC test with DHCP network configure"
- name: "GOSC test with DHCP network configuration"
include_tasks: win_gosc_workflow.yml
4 changes: 2 additions & 2 deletions windows/guest_customization/gosc_sanity_staticip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: BSD-2-Clause
---
# Description:
# This test case is used for check guest OS customization (GOSC)
# This test case is used for checking guest OS customization (GOSC)
# with static network configuration. If VMware Tools is not installed,
# the test result is 'Blocked'.
# Note: VM guest OS customization requires vCenter server.
Expand All @@ -13,5 +13,5 @@
vars:
gosc_network_type: "static"
tasks:
- name: "GOSC test with static network configure"
- name: "GOSC test with static network configuration"
include_tasks: win_gosc_workflow.yml
2 changes: 1 addition & 1 deletion windows/guest_customization/win_gosc_prepare.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
- name: "Decrypt Bitlocker volumes"
include_tasks: ../utils/win_decrypt_bitlocker_volume.yml

- name: "Shutdown guest OS before execute GOSC"
- name: "Shutdown guest OS before executing GOSC"
include_tasks: ../utils/win_shutdown_restart.yml
vars:
set_win_power_state: "shutdown"

0 comments on commit f67b99a

Please sign in to comment.