Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix ping result is true when host unreachable issue #302

Merged
merged 2 commits into from May 16, 2022

Conversation

Tomorrow9
Copy link
Member

Signed-off-by: dianew dianew@vmware.com
Fixes #300

Signed-off-by: dianew <dianew@vmware.com>
@Tomorrow9 Tomorrow9 added this to the v2.0 milestone May 13, 2022
@Tomorrow9
Copy link
Member Author

VM information:
+-----------------------------------------------------------------------------------------+
| Name                      | test_vm                                                     |
+-----------------------------------------------------------------------------------------+
| IP                        |                                             |
+-----------------------------------------------------------------------------------------+
| Guest OS Distribution     | Microsoft Windows Server 2022 Datacenter                    |
|                           | 10.0.25114.0 64-bit                                         |
+-----------------------------------------------------------------------------------------+
| Hardware Version          | vmx-19                                                      |
+-----------------------------------------------------------------------------------------+
| VMTools Version           | 11.3.5.31214 (build-18557794)                               |
+-----------------------------------------------------------------------------------------+
| Config Guest Id           | windows2019srvNext_64Guest                                  |
+-----------------------------------------------------------------------------------------+
| GuestInfo Guest Id        | windows2019srvNext_64Guest                                  |
+-----------------------------------------------------------------------------------------+
| GuestInfo Guest Full Name | Microsoft Windows Server 2022 (64-bit)                      |
+-----------------------------------------------------------------------------------------+
| GuestInfo Guest Family    | windowsGuest                                                |
+-----------------------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                                          |
|                           | bitness='64'                                                |
|                           | buildNumber='25114'                                         |
|                           | distroName='Windows'                                        |
|                           | distroVersion='10.0'                                        |
|                           | familyName='Windows'                                        |
|                           | kernelVersion='25114.1001'                                  |
|                           | prettyName='Windows Server 2022, 64-bit (Build 25114.1001)' |
+-----------------------------------------------------------------------------------------+


Test Results (Total: 2, Passed: 2, Elapsed Time: 00:09:15)
+-------------------------------------------------+
| Name                       | Status | Exec Time |
+-------------------------------------------------+
| e1000e_network_device_ops  | Passed | 00:04:50  |
| vmxnet3_network_device_ops | Passed | 00:03:28  |
+-------------------------------------------------+

Signed-off-by: dianew <dianew@vmware.com>
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9 Tomorrow9 merged commit 4cdce24 into vmware:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Windows] Handle different kind of ping target IP failures
2 participants