Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Read vars_file" for every playbook #447

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Remove "Read vars_file" for every playbook #447

merged 3 commits into from
Mar 30, 2023

Conversation

Winnie81
Copy link
Contributor

@Winnie81 Winnie81 commented Mar 28, 2023 •
edited by keirazhang

Fix #409 Remove "Read vars_file" for Linux vm deployment and test passed.

@vmwclabot
Copy link
Member

@Winnie81, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Winnie81 Winnie81 self-assigned this Mar 28, 2023
@keirazhang keirazhang changed the title Remove "Read vars_file" for Linux vm deployment [WIP] Remove "Read vars_file" for Linux vm deployment Mar 28, 2023
@vmwclabot
Copy link
Member

@Winnie81, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@Winnie81
Fix GOSV-2297: deploy linux vm
122955f 
Signed-off-by: Winnie81 <wyue@vmware.com>
@Winnie81
Fix GOSV-2297: remove read vars_file
ba82371 
Signed-off-by: Winnie81 <wyue@vmware.com>
@Winnie81 Winnie81 changed the title [WIP] Remove "Read vars_file" for Linux vm deployment Remove "Read vars_file" for every playbook Mar 30, 2023
@keirazhang keirazhang added this to the v2.3 milestone Mar 30, 2023
@Winnie81
modify file path for test.yml
39bce6f 
Signed-off-by: Winnie81 <wyue@vmware.com>
keirazhang
keirazhang previously approved these changes Mar 30, 2023
View reviewed changes
keirazhang
keirazhang approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Winnie81 Winnie81 merged commit b0db6c8 into vmware:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomorrow9 Tomorrow9 Tomorrow9 left review comments

@keirazhang keirazhang keirazhang approved these changes

Assignees

@Winnie81 Winnie81

Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

[New Feature] Too many "Read vars_file '{{ testing_vars_file | default('../vars/test.yml') }}'"
4 participants
@Winnie81 @vmwclabot @keirazhang @Tomorrow9