Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip secureboot and nvdimm testing for guest OS not supporting them #470

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Skip secureboot and nvdimm testing for guest OS not supporting them #470

merged 3 commits into from
Jun 8, 2023

Conversation

keirazhang
Copy link
Contributor

Skip secureboot_enable_disable for Pardus, UOS, ProLinux.
Skip nvdimm_cold_add_remove for UOS, Amazon Linux and Ubuntu Cloud Image.

@keirazhang keirazhang added this to the v3.0 milestone Jun 6, 2023
@keirazhang
Copy link
Contributor Author

Test results:

  - 'Guest os distribution: Ubuntu 20.04 CloudImage x86_64'
  - 'Hardware version: vmx-21'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu''
    distroVersion=''20.04'' familyName=''Linux'' kernelVersion=''5.4.0-139-generic''
    prettyName=''Ubuntu 20.04.5 LTS'''
  - 'Results: Total (4), Passed (2), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * secureboot_enable_disable...............................Not Applicable'
  - ' * nvdimm_cold_add_remove...................................Not Supported'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Amazon 2 x86_64'
  - 'Hardware version: vmx-21'
  - 'Config guest id: other3xLinux64Guest'
  - 'Guestinfo guest id: amazonlinux2_64Guest'
  - 'Guestinfo guest full name: Amazon Linux 2 (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Amazon
    Linux'' distroVersion=''2'' familyName=''Linux'' kernelVersion=''4.14.301-224.520.amzn2.x86_64''
    prettyName=''Amazon Linux 2'''
  - 'Results: Total (4), Passed (2), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * secureboot_enable_disable...............................Not Applicable'
  - ' * nvdimm_cold_add_remove...................................Not Supported'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 23.04 CloudImage x86_64'
  - 'Hardware version: vmx-21'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    23.04'' distroVersion=''23.04'' familyName=''Linux'' kernelVersion=''6.2.0-20-generic''
    prettyName=''Ubuntu 23.04'''
  - 'Results: Total (4), Passed (2), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * secureboot_enable_disable...............................Not Applicable'
  - ' * nvdimm_cold_add_remove...................................Not Supported'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 22.04 CloudImage x86_64'
  - 'Hardware version: vmx-21'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    22.04 LTS'' distroVersion=''22.04'' familyName=''Linux'' kernelVersion=''5.15.0-25-generic''
    prettyName=''Ubuntu 22.04 LTS'''
  - 'Results: Total (4), Passed (2), Skipped (2)'
  - ' * deploy_vm_ova...................................................Passed'
  - ' * secureboot_enable_disable...............................Not Applicable'
  - ' * nvdimm_cold_add_remove...................................Not Supported'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 23.04 Desktop x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    23.04'' distroVersion=''23.04'' familyName=''Linux'' kernelVersion=''6.2.0-20-generic''
    prettyName=''Ubuntu 23.04'''
  - 'Results: Total (4), Passed (4)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable.......................................Passed'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: ProLinux 8.5 x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: other4xLinux64Guest'
  - 'Guestinfo guest id: other4xLinux64Guest'
  - 'Guestinfo guest full name: Other 4.x Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: bitness=''64'' distroName=''ProLinux'' distroVersion=''8.5''
    familyName=''Linux'' kernelVersion=''4.18.0-348.el8.x86_64'' prettyName=''ProLinux
    8.5'''
  - 'Results: Total (4), Passed (3), Skipped (1)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable................................Not Supported'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 20.04 Server x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu''
    distroVersion=''20.04'' familyName=''Linux'' kernelVersion=''5.4.0-144-generic''
    prettyName=''Ubuntu 20.04.6 LTS'''
  - 'Results: Total (4), Passed (4)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable.......................................Passed'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'

  - 'Guest os distribution: ProLinux 7.9 x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: other3xLinux64Guest'
  - 'Guestinfo guest id: other3xLinux64Guest'
  - 'Guestinfo guest full name: Other 3.x Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: bitness=''64'' distroName=''ProLinux Server'' distroVersion=''7.9''
    familyName=''Linux'' kernelVersion=''3.10.0-1160.el7.x86_64'' prettyName=''ProLinux
    7.9'''
  - 'Results: Total (4), Passed (3), Skipped (1)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable................................Not Supported'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'

  - 'Guest os distribution: Ubuntu 22.04 Desktop x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    22.04.2 LTS'' distroVersion=''22.04'' familyName=''Linux'' kernelVersion=''5.19.0-43-generic''
    prettyName=''Ubuntu 22.04.2 LTS'''
  - 'Results: Total (4), Passed (4)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable.......................................Passed'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 23.04 Server x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    23.04'' distroVersion=''23.04'' familyName=''Linux'' kernelVersion=''6.2.0-20-generic''
    prettyName=''Ubuntu 23.04'''
  - 'Testset folder: Root\ALPS\Keira\Ansible\GOSV_Async_Pipeline\1334_20230605-033844'
  - 'Testset name: Ansible_Regression_Ubuntu_23.04_Server_ISO'
  - 'Testset id: 1238095'
  - 'Results: Total (4), Passed (4)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable.......................................Passed'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: UnionTech 20 x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: other4xLinux64Guest'
  - 'Guestinfo guest id: other5xLinux64Guest'
  - 'Guestinfo guest full name: Other 5.x Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''UnionTech
    OS Server 20'' distroVersion=''20'' familyName=''Linux'' kernelVersion=''5.10.0-18.uelc20.x86_64''
    prettyName=''UnionTech OS Server 20'''
  - 'Results: Total (4), Passed (2), Skipped (2)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable................................Not Supported'
  - ' * nvdimm_cold_add_remove...................................Not Supported'
  - ' * check_os_fullname...............................................Passed'


  - 'Guest os distribution: Ubuntu 22.04 Server x86_64'
  - 'Hardware version: vmx-20'
  - 'Config guest id: ubuntu64Guest'
  - 'Guestinfo guest id: ubuntu64Guest'
  - 'Guestinfo guest full name: Ubuntu Linux (64-bit)'
  - 'Guestinfo guest family: linuxGuest'
  - 'Guestinfo detailed data: architecture=''X86'' bitness=''64'' distroName=''Ubuntu
    22.04.2 LTS'' distroVersion=''22.04'' familyName=''Linux'' kernelVersion=''5.15.0-73-generic''
    prettyName=''Ubuntu 22.04.2 LTS'''
  - 'Results: Total (4), Passed (4)'
  - ' * deploy_vm_efi_paravirtual_vmxnet3...............................Passed'
  - ' * secureboot_enable_disable.......................................Passed'
  - ' * nvdimm_cold_add_remove..........................................Passed'
  - ' * check_os_fullname...............................................Passed'

@keirazhang
Add tasks names
e7b7262 
Signed-off-by: Qi Zhang <qiz@vmware.com>
123lzxm
123lzxm previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minor comment. Thanks.

linux/nvdimm_cold_add_remove/nvdimm_cold_add_remove.yml Outdated Show resolved Hide resolved
@keirazhang
Remove single quote
0b83a4b 
Signed-off-by: Qi Zhang <qiz@vmware.com>
123lzxm
123lzxm approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@keirazhang keirazhang merged commit edac87f into vmware:main Jun 8, 2023
@keirazhang keirazhang mentioned this pull request Jun 8, 2023
Closed
@keirazhang keirazhang deleted the skip_secureboot_nvdimm branch August 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keirazhang @123lzxm