Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] fix undefine error for guest_os_with_inbox_drivers in network case #494

Merged
merged 4 commits into from
Aug 22, 2023
Merged

[Windows] fix undefine error for guest_os_with_inbox_drivers in network case #494

merged 4 commits into from
Aug 22, 2023

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Aug 22, 2023

No description provided.

@123lzxm
fix undefine error for guest_os_with_inbox_drivers
9c78531 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Copy link
Collaborator Author

123lzxm commented Aug 22, 2023 

Test Results (Total: 1, Passed: 1, Elapsed Time: 00:17:43)
+------------------------------------------------------+
| ID | Name                       | Status | Exec Time |
+------------------------------------------------------+
|  1 | vmxnet3_network_device_ops | Passed | 00:11:56  |
+------------------------------------------------------+

Test Results (Total: 2, Passed: 2, Elapsed Time: 00:18:26)
+------------------------------------------------------+
| ID | Name                       | Status | Exec Time |
+------------------------------------------------------+
|  1 | check_efi_firmware         | Passed | 00:02:05  |
|  2 | vmxnet3_network_device_ops | Passed | 00:10:34  |
+------------------------------------------------------+

@123lzxm
address comments
e942f3c 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
check if tools installed
7174e8e 
Signed-off-by: Yanan Shen <yanans@vmware.com>
@123lzxm
Modify message
2da3f4c 
Signed-off-by: Yanan Shen <yanans@vmware.com>
keirazhang
keirazhang approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@123lzxm 123lzxm merged commit 456a7e3 into vmware:main Aug 22, 2023
@keirazhang keirazhang added this to the v3.0 milestone Sep 27, 2023
@123lzxm 123lzxm deleted the fix-vmxnet3-var branch November 8, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@123lzxm @keirazhang