Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Check vmtools_log_dir is defined before using in check_os_fullname #498

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

keirazhang
Copy link
Contributor

When test failed at test_setup, it won't define vmtools_log_dir, but at always block, this var is used. So here needs to check vmtools_log_dir is defined.

Signed-off-by: Qi Zhang <qiz@vmware.com>
@keirazhang keirazhang added this to the v3.0 milestone Sep 7, 2023
@keirazhang keirazhang changed the title Check vmtools_log_dir is defined before using [Linux] Check vmtools_log_dir is defined before using in check_os_fullname Sep 7, 2023
Signed-off-by: Qi Zhang <qiz@vmware.com>
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@keirazhang keirazhang merged commit e56103a into vmware:main Sep 8, 2023
@keirazhang keirazhang deleted the fix-2912 branch March 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants