Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrotsc] (#215) Upgrade vrotsc TS from 3.8.3 to 5.4.5 #245

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

Rehiq
Copy link
Contributor

@Rehiq Rehiq commented Mar 1, 2024

Description

Checklist

  • I have added relevant error handling and logging messages to help troubleshooting
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation, relevant usage information (if applicable)
  • I have updated CHANGELOG.md with a short summary of the changes introduced
  • I have tested against live environment, if applicable
  • I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
  • I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
  • I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Related issues and PRs

@Rehiq Rehiq requested a review from a team as a code owner March 1, 2024 15:16
@Rehiq Rehiq force-pushed the 215-upgrade-to-new-ts-version branch 3 times, most recently from 76b5212 to b12bf83 Compare March 1, 2024 15:37
@github-actions github-actions bot added the Stale label Apr 1, 2024
@VenelinBakalov
Copy link
Contributor

PR is not stale, it is currently in test

@github-actions github-actions bot removed the Stale label Apr 2, 2024
@vmware vmware deleted a comment from vmwclabot Apr 19, 2024
@vmware vmware deleted a comment from vmwclabot Apr 19, 2024
@vmware vmware deleted a comment from vmwclabot Apr 19, 2024
@vmware vmware deleted a comment from vmwclabot Apr 19, 2024
@vmwclabot
Copy link
Member

@Rehiq, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

2 similar comments
@vmwclabot
Copy link
Member

@Rehiq, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@Rehiq, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmware vmware deleted a comment from github-actions bot Apr 22, 2024
@akantchev
Copy link
Contributor

akantchev commented May 15, 2024

I did some tests with building projects with the latest version of vrotsc, everything seems to work fine, however there is a need for it to be merged from the main branch (as there are some conflicts), @Rehiq , could you please merge the changes from the main branch to this one.
Conflicting file: typescript/vrotsc/src/compiler/transformer/fileTransformers/policyTemplate.ts

Copy link
Contributor

@VenelinBakalov VenelinBakalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting temporarily on hold until we decide when to merge and release this one

@Rehiq Rehiq force-pushed the 215-upgrade-to-new-ts-version branch from 48e054d to 5f36590 Compare June 12, 2024 10:59
@Rehiq Rehiq changed the title Upgrade vrotsc ts to 5.3.3 Upgrade vrotsc ts to 5.4.5 Jun 12, 2024
Anton Ivanov added 2 commits June 12, 2024 15:39
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
@Rehiq Rehiq force-pushed the 215-upgrade-to-new-ts-version branch from 2a6f98b to e169cdf Compare June 12, 2024 13:02
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
@VenelinBakalov VenelinBakalov added the enhancement New feature or request label Jun 17, 2024
Anton Ivanov added 3 commits June 17, 2024 10:47
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
Signed-off-by: Anton Ivanov <anton.ivanov@broadcom.com>
@akantchev akantchev requested a review from joroaf June 17, 2024 11:07
@vmware vmware deleted a comment from vmwclabot Jun 17, 2024
@Rehiq Rehiq merged commit 20e42ec into main Jun 17, 2024
12 checks passed
@VenelinBakalov VenelinBakalov added bug Something isn't working major minor enhancement New feature or request and removed enhancement New feature or request minor bug Something isn't working major labels Jun 18, 2024
@VenelinBakalov VenelinBakalov changed the title Upgrade vrotsc ts to 5.4.5 Support Upgrade vrotsc ts to 5.4.5 Jun 18, 2024
@VenelinBakalov VenelinBakalov added enhancement New feature or request and removed enhancement New feature or request labels Jun 18, 2024
@VenelinBakalov VenelinBakalov changed the title Support Upgrade vrotsc ts to 5.4.5 Upgrade vrotsc ts to 5.4.5 Jun 18, 2024
@VenelinBakalov VenelinBakalov changed the title Upgrade vrotsc ts to 5.4.5 [vrotsc] (#215) Upgrade vrotsc TS from 3.8.3 to 5.4.5 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants