Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

ClarityIcons size attribute is not controlling the size of non-svg elements #1567

Closed
Shijir opened this issue Oct 10, 2017 · 1 comment
Closed
Assignees
Milestone

Comments

@Shijir
Copy link
Contributor

Shijir commented Oct 10, 2017

Select one ... (check one with "x")

[ x] bug
[ ] feature request
[ ] enhancement

Expected behavior

The non-svg elements inside clr-icons shouldn't exceed the specified size given.

Actual behavior

If I use a large-size image as a template for an icon, the template elements would not be contained within the boundaries specified in the clr-icon size attribute.
https://github.com/vmware/clarity/blob/master/src/clarity-icons/clarity-icons.scss#L98

This is because we specified size only when clr-icon element contains svg element as a template.

https://plnkr.co/edit/OIspai?p=preview

Reproduction of behavior

  • Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

Environment details

  • Angular version: 4.x.x

  • Clarity version:

  • OS and version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants