This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(input): add top padding to cds-input elements #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisscott
suggested changes
Jun 14, 2021
packages/core/src/forms/control-label/control-label.element.scss
Outdated
Show resolved
Hide resolved
coryrylan
reviewed
Jun 14, 2021
packages/core/src/forms/control-label/control-label.element.scss
Outdated
Show resolved
Hide resolved
|
I needed to bump it to
|
mathisscott
suggested changes
Jun 14, 2021
mathisscott
approved these changes
Jun 14, 2021
hippee-lee
changed the title
coryrylan
approved these changes
Jun 15, 2021
This seems to fix an alignment issue with formcontrol labels and form inputs. closes vmware-archive#6044 Signed-off-by: Matt Hippely <mhippely@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix an alignment issue with form control labels and form inputs.
closes #6044
Before and after screen shots:
Signed-off-by: Matt Hippely mhippely@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This remove line height from control label elements.
What is the current behavior?
The
control label textandcontrol input textis mis-aligned.Issue Number: #6044
What is the new behavior?
Control label text aligns with control input text.
Does this PR introduce a breaking change?
Other information