Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

JS Name change required. #850

Closed
xrobau opened this issue May 8, 2017 · 7 comments · Fixed by #1733
Closed

JS Name change required. #850

xrobau opened this issue May 8, 2017 · 7 comments · Fixed by #1733
Assignees
@hippee-lee
Milestone
0.11.0

Comments

@xrobau
Copy link

xrobau commented May 8, 2017

Select one ... (check one with "x")

[ ] bug
[x] feature request
[ ] enhancement

Expected behavior

HTML5 console works.

Actual behavior

HTML5 console breaks because 'clarity-*.js' is blocked by EasyList.

Reproduction of behavior

EasyList (which is used by a large number of adblockers) blocks any javascript called 'clarity-*.js'. See here for more information. Opening vCenter console with any browser with EasyList enabled makes the HTML5 console crash.

At the very least, vCenter should detect that Clarity is missing an tell people to disable their ad blocker, rather than whitepage.

Environment details

  • Browser: Anything with uBlock Origin, or most other web browsers.
@jaffoneh
Copy link
Contributor

jaffoneh commented May 8, 2017

We've been actually discussing this internally. Clarity itself does not ship a clarity-*.js file, it is the naming used within the HTML5 web client and that is about to change to support the case mentioned above. Closing based on the above considering this is not a Clarity issue and cannot be solved within Clarity.

@jaffoneh jaffoneh closed this as completed May 8, 2017
@bdunkz
Copy link
Contributor

bdunkz commented May 8, 2017

Just to add some additional details: the latest Fling releases no longer request a clarity-*.js file and the next vCenter update/patch is also covered.

@TobiX TobiX mentioned this issue Jul 29, 2017
Closed
@mathisscott mathisscott reopened this Oct 17, 2017
@mathisscott mathisscott self-assigned this Oct 17, 2017
@mathisscott
Copy link
Contributor

I've left a response on the EasyList forum for this issue. I'm hoping to hear back at some point.

If not, I will try emailing them directly to get direction on next steps. If the answer is for us to change the name of our deliverables, we need to come to an understanding that will prevent this issue from resurfacing in the future.

It's also a little silly that they have refused to whitelist our packages. We have three of them... 🙄

@mathisscott mathisscott added ClarityCore status: needs info Need more information from the issue author. labels Oct 17, 2017
@mathisscott mathisscott added this to the 0.10.12 milestone Oct 18, 2017
@mathisscott mathisscott removed the status: needs info Need more information from the issue author. label Oct 19, 2017
@jonathantrevor jonathantrevor mentioned this issue Oct 20, 2017
Closed
mathisscott pushed a commit to mathisscott/easylist that referenced this issue Oct 25, 2017
Whitelisting VMware Clarity libraries
10b46ba 
I tried to be as explicit as possible and placed this next to the other whitelisted entry using the blocked “clarity-*” string.

Please see:

https://forums.lanik.us/viewtopic.php?f=64&t=35937&p=117983&hilit=clarity#p117983

…and…

vmware-archive/clarity#850

…for reference.

Signed-off-by: Scott Mathis <smathis@vmware.com>
@mathisscott mathisscott mentioned this issue Oct 25, 2017
Closed
@mathisscott
Copy link
Contributor

We'll see if this works...

easylist/easylist#683

Note that they are already whitelisting someone that is blocked by the clarity-*.js rule. So it seems a little hypocritical that they would make an exception in that case and not ours...

mathisscott pushed a commit to mathisscott/easylist that referenced this issue Oct 25, 2017
Whitelisting VMware Clarity libraries
4f73238 
I tried to be as explicit as possible and placed this next to the other whitelisted entry using the blocked “clarity-*” string.

Please see:

https://forums.lanik.us/viewtopic.php?f=64&t=35937&p=117983&hilit=clarity#p117983

…and…

vmware-archive/clarity#850

…for reference.

Signed-off-by: Scott Mathis <smathis@vmware.com>

Update based on PR comment
@mathisscott
Copy link
Contributor

I'm going to need some help from @jeeyun to work through a webpack issue I'm hitting with this.

@mathisscott mathisscott modified the milestones: 0.10.12, 0.10.13 Oct 27, 2017
@mathisscott
Copy link
Contributor

@jeeyun : Nevermind on previous comment. @hippee-lee helped me out. I just have one more hurdle to figure out. I'm hoping to have something to discuss on this on next Tuesday's standup. I know you're still out so no worries on that. ❤️

@mathisscott mathisscott modified the milestones: 0.10.13, 0.11.0 Nov 2, 2017
@mathisscott mathisscott assigned hippee-lee and unassigned mathisscott Nov 6, 2017
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Nov 29, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
79c4304 
- Updates to filenames that would be blacklisted by easylist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Nov 30, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
b52db2b 
- Updates to filenames that would be blacklisted by easylist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Nov 30, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
95152bc 
- Updates to filenames that would be blacklisted by easylist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Nov 30, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
b982c0d 
- Updates to filenames that are not in the easylist blacklist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
@hippee-lee hippee-lee mentioned this issue Nov 30, 2017
Merged
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Dec 11, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
4b83e64 
- Updates to filenames that are not in the easylist blacklist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
gnomeontherun pushed a commit to hippee-lee/clarity that referenced this issue Dec 14, 2017
@hippee-lee @gnomeontherun
[CORE] Adds scoped naming and new package file names
b24212b 
- Updates to filenames that are not in the easylist blacklist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Dec 14, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
4ee2216 
- Updates to filenames that are not in the easylist blacklist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes vmware-archive#850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit that referenced this issue Dec 15, 2017
@hippee-lee
[CORE] Adds scoped naming and new package file names
3161d38 
- Updates to filenames that are not in the easylist blacklist
- Generated packages for the @clr scope on npm
- Updates demo and ks-app for the @clr scope
- closes #850

Signed-off-by: Matt Hippely <mhippely@vmware.com>
@hippee-lee hippee-lee mentioned this issue Dec 18, 2017
Closed
1 task
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hippee-lee hippee-lee

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

[CORE] Adds scoped naming and new package file names hippee-lee/clarity
5 participants
@hippee-lee @xrobau @jaffoneh @mathisscott @bdunkz