Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Bluesky #2899

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Bluesky #2899

merged 1 commit into from
Dec 17, 2018

Conversation

gnomeontherun
Copy link
Contributor

@gnomeontherun gnomeontherun commented Nov 30, 2018 •
edited
Loading

This moves the website into the master branch so we can better version the website. It also moves all assets from this repo into clarity-assets and links over to them.

@vmwclabot
Copy link

@gnomeontherun, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@gnomeontherun, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@gnomeontherun, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

jeeyun
jeeyun reviewed Dec 13, 2018
View reviewed changes
src/website/src/app/utils/sketch-template-link.directive.ts

@HostBinding('attr.href')
get href() {
return `assets/images/sketchTemplates/Clarity-Template-${this.version}.sketch`;
return `${environment.sketch_base_url}/${this.type}/clarity-library-${this.type}-${this.version}.sketch`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

jeeyun
jeeyun reviewed Dec 13, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
Shijir
Shijir approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@Shijir Shijir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for answering all my epistemological questions 👍 😄

@mathisscott mathisscott added this to the 1.0.3 milestone Dec 14, 2018
hippee-lee
hippee-lee approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@hippee-lee hippee-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with renaming the website related scripts that are not prefixed with website but I don't feel its a big enough issue to block this. Thanks for adding the pieces in place for netlify to be used in the future.

@gnomeontherun
Copy link
Contributor Author

@hippee-lee I pushed a commit with better script names, so that is resolved.

@gnomeontherun
[WEBSITE] adding the website to the main project
03d6927 
This is a whole sale move of the files from the existing website branch over to master, which will allow us to do docs and features at the same time. It also includes the basics for netlify to use as a deployment platform, fixes up all linting and build issues, and is in sync with latest website.

Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
@gnomeontherun gnomeontherun merged commit f19ad29 into master Dec 17, 2018
Shijir pushed a commit to Shijir/clarity that referenced this pull request Dec 18, 2018
@gnomeontherun @Shijir
[WEBSITE] adding the website to the main project (vmware-archive#2899)
5238c06 
This is a whole sale move of the files from the existing website branch over to master, which will allow us to do docs and features at the same time. It also includes the basics for netlify to use as a deployment platform, fixes up all linting and build issues, and is in sync with latest website.

Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
@gnomeontherun gnomeontherun deleted the bluesky branch September 2, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeeyun jeeyun jeeyun left review comments

@hippee-lee hippee-lee hippee-lee approved these changes

@Shijir Shijir Shijir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@gnomeontherun @vmwclabot @hippee-lee @jeeyun @Shijir @mattmutt @mathisscott